After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676407 - Don't enable backlight helper if GUdev is not available
Don't enable backlight helper if GUdev is not available
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-20 04:17 UTC by Michael Biebl
Modified: 2012-06-15 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't enable backlight helper if GUdev is not available (1.51 KB, patch)
2012-05-20 04:21 UTC, Michael Biebl 		needs-work Details | Review
[PATCH 1/2] build: Use lower case have_gudev (1.45 KB, patch)
2012-06-14 21:04 UTC, Michael Biebl 		committed Details | Review
[PATCH 2/2] build: Don't enable backlight helper if GUdev is not available (855 bytes, patch)
2012-06-14 21:04 UTC, Michael Biebl 		none Details | Review
[PATCH 2/2] build: Don't enable backlight helper if GUdev is not available (951 bytes, patch)
2012-06-14 21:17 UTC, Michael Biebl 		committed Details | Review

Description Michael Biebl 2012-05-20 04:17:55 UTC 
Don't enable backlight helper if GUdev is not available.
We should check for have_gudev, not enable_gudev in this case.
Comment 1 Michael Biebl 2012-05-20 04:21:27 UTC 
Created attachment 214476 [details] [review]
Don't enable backlight helper if GUdev is not available
Comment 2 Matthias Clasen 2012-06-14 04:06:03 UTC 
Review of attachment 214476 [details] [review]:

looks right to me
Comment 3 Bastien Nocera 2012-06-14 09:31:53 UTC 
Review of attachment 214476 [details] [review]:

::: gnome-settings-daemon-3.4.2.orig/configure.ac
@@ +140,3 @@
 AC_ARG_ENABLE(gudev, AS_HELP_STRING([--disable-gudev],[Disable GUdev support]), enable_gudev=$enableval)
 if test x$enable_gudev != xno; then
+	PKG_CHECK_MODULES(GUDEV, gudev-1.0, have_gudev="yes", have_gudev="no")

You're making a single commit to change HAVE_GUDEV to have_gudev, and fix the bug.

Please split this in 2 commits.
Comment 4 Michael Biebl 2012-06-14 21:04:19 UTC 
Created attachment 216467 [details] [review]
[PATCH 1/2] build: Use lower case have_gudev
Comment 5 Michael Biebl 2012-06-14 21:04:51 UTC 
Created attachment 216468 [details] [review]
[PATCH 2/2] build: Don't enable backlight helper if GUdev is not  available
Comment 6 Michael Biebl 2012-06-14 21:17:43 UTC 
Created attachment 216470 [details] [review]
[PATCH 2/2] build: Don't enable backlight helper if GUdev is not  available