GNOME Bugzilla – Bug 676379
Obey *-upload-folder settings
Last modified: 2018-05-22 12:34:32 UTC
And while doing that, make those folders a) shared if they aren't b) make those the _only_ folders we upload to instead of every folder
I've noticed that any media I upload to the AnyContainer using the MediaExport plugin always ends up in ~/Pictures, even if I'm uploading an audio file. Here's an example of the CreateObject requests that I'm sending. <DIDL-Lite xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" xmlns="urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/"> <item id="" parentID="DLNA.ORG_AnyContainer" restricted="0"> <dc:title>O-MP3-8.mp3</dc:title> <upnp:class>object.item.audioItem</upnp:class> <res protocolInfo="*:*:audio/mpeg:DLNA.ORG_PN=MP3"/> </item> </DIDL-Lite> Is this the same bug? If not, I'll enter a new one.
yes, that's the same bug, part b)
b) actually should only apply for AnyContainer uploads, otherwise a true sync is not possible.
Actually, I have another question about this. Do we need a new upload folder for playlists items?
Good point.
Thought a bit about this, one thing we need to make sure is that we don't accidentaly share stuff that isn't supposed to be shared, the upload folders point to the standard XDG folders by default.
Created attachment 246410 [details] [review] media-export: Use upload folder settings When a client tries to upload a file, try to use the configured upload folders instead of just picking some random folder to upload to.
First draft, not fixing all of the problems, but getting there. One thing I'm not particularly sure about is whether to just return the upload folder or manipulating the results list and putting the upload folder on first place.
Created attachment 246502 [details] [review] media-export: Use upload folder settings When a client tries to upload a file, try to use the configured upload folders instead of just picking some random folder to upload to.
Missing: set createClass of these folders to the relevant ones only
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rygel/issues/19.