After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676371 - shell-app: Raise windows in reverse order to preserve the stacking
shell-app: Raise windows in reverse order to preserve the stacking
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-19 15:32 UTC by Rui Matos
Modified: 2012-05-19 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-app: Raise windows in reverse order to preserve the stacking (1.83 KB, patch)
2012-05-19 15:32 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-05-19 15:32:10 UTC 
ShellApp keeps track of windows sorted by most recently used first
which means that when raising windows we need to start from the end of
the list to finish with the correct stacking order.

This patch just makes the code agree with the comment which was
already there.
Comment 1 Rui Matos 2012-05-19 15:32:13 UTC 
Created attachment 214443 [details] [review]
shell-app: Raise windows in reverse order to preserve the stacking
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-05-19 17:52:16 UTC 
Review of attachment 214443 [details] [review]:

uhhh

So you're telling me that we did this wrong all along? I don't believe you.
Comment 3 Rui Matos 2012-05-19 19:26:35 UTC 
(In reply to comment #2)
> So you're telling me that we did this wrong all along? I don't believe you.

This has actually bugged me since forever but only today was I really annoyed enough to dig in and fix it :-)

To test it try this:

1. In an empty workspace open 3 terminal windows A, B, C and some other app;
2. Arrange them so that the stacking is clearly visible to you;
3. Focus each one of the terminal windows in turn by clicking on each in the order A, B, C;
4. Alt+Tab into the other app;
5. Alt+Tab back to the terminal app;
6. You should see the terminal windows stacked like (from top to bottom) C, A, B.

This patch makes it stack correctly at the end like C, B, A.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-05-19 19:35:09 UTC 
Review of attachment 214443 [details] [review]:

Sure, then.
Comment 5 Rui Matos 2012-05-19 20:05:32 UTC 
Attachment 214443 [details] pushed as b61ada7 - shell-app: Raise windows in reverse order to preserve the stacking