GNOME Bugzilla – Bug 676320
User is not created during unattended installation of WinXP
Last modified: 2016-03-31 13:54:22 UTC
Cloning https://bugzilla.redhat.com/show_bug.cgi?id=822499 : Description of problem: I selected name and password for new user in setup phase, but this user is not created. There is Administrator with right password (which I set), but no user. Version-Release number of selected component (if applicable): gnome-boxes-3.4.2-1.fc17.x86_64 How reproducible: 100% Steps to Reproduce: 1. Create new vm 2. choose xp installation media 3. in Setup set: Express install - ON, user - foo, password - bar, product key 4. install Actual results: user is not created. Administrator user has setted password Expected results: There is no Name in setup or new user with given name is created.
Created attachment 214628 [details] [review] Move exec* helpers to where they belong: Util module
Created attachment 214629 [details] [review] express,winxp: Create user account & enable autologon We weren't really creating a user account based on the information provided. This patch fixes it. I tried very hard to find a less intrusive way to accomplish this but I failed.
Review of attachment 214628 [details] [review]: ack
Review of attachment 214629 [details] [review]: patch looks good, ack
Created attachment 214671 [details] [review] express,winxp: Create user account & enable autologon This version takes care of empty password case.
Hmm not a big fan of UnattendedFile actually being an UnattendedTextFile since I'll need to use this with binary files ;)
Created attachment 214681 [details] [review] express,winxp,win2k3: Setup user account & autologon Just a minor update: Don't forget to apply the changes to Windows 2003.
(In reply to comment #6) > Hmm not a big fan of UnattendedFile actually being an UnattendedTextFile since > I'll need to use this with binary files ;) Actually I'm already using this for a binary file myself: user logo and what I'm doing is that i make a subclass of UnattendedFile that does a different conversion. I'd suggest you do the same for your binaries.
(In reply to comment #8) > (In reply to comment #6) > > Hmm not a big fan of UnattendedFile actually being an UnattendedTextFile since > > I'll need to use this with binary files ;) > > Actually I'm already using this for a binary file myself: user logo and what > I'm doing is that i make a subclass of UnattendedFile that does a different > conversion. I'd suggest you do the same for your binaries. Subclassing to get a more generic behaviour sounds backwards to me.
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #6) > > > Hmm not a big fan of UnattendedFile actually being an UnattendedTextFile since > > > I'll need to use this with binary files ;) > > > > Actually I'm already using this for a binary file myself: user logo and what > > I'm doing is that i make a subclass of UnattendedFile that does a different > > conversion. I'd suggest you do the same for your binaries. > > Subclassing to get a more generic behaviour sounds backwards to me. Its not more generic but rather one specific to another specific but yeah, i could create an interface and 2 implementations instead..
Comment on attachment 214681 [details] [review] express,winxp,win2k3: Setup user account & autologon As I said on IRC, I'll create the generic interface and rename this class as part of the WIP patch that installs user's avatar.