After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676307 - Cannot leave full screen before system bootup (not even with keyboard)
Cannot leave full screen before system bootup (not even with keyboard)
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.4.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-05-18 11:10 UTC by Vitezslav Humpa
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Always show topbar when mouse can be grabbed (8.29 KB, patch)
2012-05-22 19:19 UTC, Marc-Andre Lureau 		committed Details | Review
Update topbar title to help with ungrab (2.12 KB, patch)
2012-05-22 19:19 UTC, Marc-Andre Lureau 		committed Details | Review

Description Vitezslav Humpa 2012-05-18 11:10:46 UTC 
While in Fedora 16 live image grub menu, before the system starts up, I can't leave full-screen, not even with ctrl+shift+F11 shortcut. Shortcut starts working as Fedora starts to load.

Happens only *sometimes* though.

gnome-boxes-3.4.2-1.fc17.x86_64
qemu-kvm-1.0-17.fc17.x86_64

Would also be useful for the Ctrk+shift+F11 shortcut to be stated somewhere, as common user might not be aware of it.
Comment 1 Marc-Andre Lureau 2012-05-22 19:19:36 UTC 
Created attachment 214691 [details] [review]
Always show topbar when mouse can be grabbed
Comment 2 Marc-Andre Lureau 2012-05-22 19:19:40 UTC 
Created attachment 214692 [details] [review]
Update topbar title to help with ungrab

This should help user in case the mouse is grabbed.
Comment 3 Zeeshan Ali 2012-05-23 20:56:03 UTC 
Review of attachment 214691 [details] [review]:

Looks good otherwise. Assuming you fix the small nitpick and that you have tested it, ACK!

::: src/display-page.vala
@@ -140,1 +145,10 @@
-    void set_overlay_toolbar_visible(bool visible) {
+     private void update_toolbar_visible() {
+         if (app.fullscreen && !can_grab_mouse)
+             toolbar.visible = false;
... 7 more ...

coding style nitpick: " ("
Comment 4 Zeeshan Ali 2012-05-23 20:58:53 UTC 
Review of attachment 214692 [details] [review]:

ACK!

::: src/display-page.vala
@@ -175,2 +175,3 @@
     }
 
+    public void update_title() {

space before '('. Same thing in the call to this function below.
Comment 5 Marc-Andre Lureau 2012-05-23 23:03:05 UTC 
Attachment 214691 [details] pushed as bc0c837 - Always show topbar when mouse can be grabbed
Attachment 214692 [details] pushed as 241b780 - Update topbar title to help with ungrab
Comment 6 Vitezslav Humpa 2012-05-24 11:36:50 UTC 
Awesomely quick fixing, this was really a bugger at times!