After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676303 - gcmd 1.2.8.15 does not compile with poppler 0.20.0
gcmd 1.2.8.15 does not compile with poppler 0.20.0
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: plugins
1.2.x
Other Linux
: Normal normal
: 1.4
Assigned To: GNOME Commander maintainer(s)
epiotr
Depends on:
Blocks:
 
 
Reported: 2012-05-18 10:05 UTC by Mamoru TASAKA
Modified: 2014-01-08 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to compile with poppler 0.20.0 (1.95 KB, patch)
2012-05-18 10:05 UTC, Mamoru TASAKA 		none Details | Review

Description Mamoru TASAKA 2012-05-18 10:05:57 UTC 
Created attachment 214298 [details] [review]
patch to compile with poppler 0.20.0

poppler 0.20.0 is released on 2012-05-10 and gnome-commander 1.2.8.15 (and perhaps latest git) does not compile with this poppler like:

/builddir/build/BUILD/gnome-commander-1.2.8.15/_builddir/../src/tags/gnome-cmd-tags-poppler.cc: 関数 ‘void gcmd_tags_poppler_init()’ 内:
/builddir/build/BUILD/gnome-commander-1.2.8.15/_builddir/../src/tags/gnome-cmd-tags-poppler.cc:55:38: エラー: ‘setErrorFunction’ was not declared in this scope

(関数 foo 内 is "in function foo", "エラー" is error).

The related change in poppler:
http://cgit.freedesktop.org/poppler/poppler/commit?id=00549400f155d8e36b4ac718603fc945858fe50d
http://cgit.freedesktop.org/poppler/poppler/commit/?id=53f94df2ce21793914ccc153ba6b2fe5cbeb8371

Downstream bug report on Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=822405

Patch is provided by Marek Kašík mkasik_AT_redhat.com
Comment 1 Pino Toscano 2012-06-02 11:33:01 UTC 
(another reason more to switch ASAP from the poppler private core API to poppler-glib, see #641842).
Comment 2 Uwe Scholz 2014-01-08 12:37:36 UTC 
Thanks! The bug provided by Marek Kašík was successfully committed in the current stable and master branch. Bug is fixed!