After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676262 - Build failure in gdk
Build failure in gdk
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-05-17 17:03 UTC by D.S. (Spider) Ljungmark
Modified: 2012-05-17 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description D.S. (Spider) Ljungmark 2012-05-17 17:03:01 UTC
on Fedora 16  (With JHBuild)


Build failure in:

  CC     gdkenumtypes.lo
  CC     gdkmarshalers.lo
  CC     gdkdisplaymanager.lo
gdkoffscreenwindow.c:221:1: error: static declaration of 'gdk_window_set_device_cursor' follows non-static declaration
gdkwindow.h:671:6: note: previous declaration of 'gdk_window_set_device_cursor' was here
gdkoffscreenwindow.c: In function 'gdk_offscreen_window_class_init':
gdkoffscreenwindow.c:737:35: error: 'gdk_offscreen_window_set_device_cursor' undeclared (first use in this function)
gdkoffscreenwindow.c:737:35: note: each undeclared identifier is reported only once for each function it appears in
gdkoffscreenwindow.c: At top level:
gdkoffscreenwindow.c:221:1: warning: 'gdk_window_set_device_cursor' defined but not used [-Wunused-function]
make[4]: *** [gdkoffscreenwindow.lo] Error 1
make[4]: Leaving directory `/home/spider/Projects/gnome/gtk+/gdk'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/spider/Projects/gnome/gtk+/gdk'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/spider/Projects/gnome/gtk+/gdk'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/spider/Projects/gnome/gtk+'
make: *** [all] Error 2



Bisected to :
f78cf0806b9351002586b0d6ac81acd1059e42fc is the first bad commit
commit f78cf0806b9351002586b0d6ac81acd1059e42fc
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu May 10 15:23:57 2012 +0100

    gdkoffscreenwindow: Don't crash when resetting cursor
    
    When the toplevel is a GdkOffscreenWindow which doesn't
    implement the set_device_cursor() vfunc, we would have
    crashed. Implement a dummy ->set_device_cursor vfunc.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=675809

:040000 040000 fc44f9643cd02f51aa128ec630b49519d20a2117 a7eb9d1115e67df696ef69a9566ae0f868a3380e M	gdk
Comment 1 André Klapper 2012-05-17 17:26:29 UTC
CC'ing hadess as per bisect result.
Comment 2 Bastien Nocera 2012-05-17 17:49:26 UTC
Fixed in gtk-3-4 and master