After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676208 - The tmpl parameter to g_file_new_tmp can be NULL
The tmpl parameter to g_file_new_tmp can be NULL
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.32.x
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-05-17 04:41 UTC by Debarshi Ray
Modified: 2012-05-21 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: The tmpl parameter to g_file_new_tmp can be NULL (692 bytes, patch)
2012-05-17 04:54 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-05-17 04:41:55 UTC 
.
Comment 1 Debarshi Ray 2012-05-17 04:54:55 UTC 
Created attachment 214233 [details] [review]
gio: The tmpl parameter to g_file_new_tmp can be NULL
Comment 2 Matthias Clasen 2012-05-17 12:19:14 UTC 
Review of attachment 214233 [details] [review]:

sure. Although I think the commit message should say something more like 'gio: Warn if tmpl is NULL in g_file_new_tmp'
Comment 3 Debarshi Ray 2012-05-21 15:55:23 UTC 
15:51 <rishi> mclasen: https://bugzilla.gnome.org/show_bug.cgi?id=676208 <--    
      Currently the patch does not warn about a NULL tmpl, it just allows it    
      because the documentation says that is a valid value.
15:52 <rishi> So what did you mean by "warn if ..." ?
15:52 <mclasen> oh, I read it the wrong way
15:52 <mclasen> you are removing the warning, not adding one
15:52 <rishi> yes :)
15:53 <mclasen> ignore my comment then
15:53 <rishi> mclasen: Does it make sense for glib-2-32 ?
15:54 <mclasen> sure, why not
15:54 <rishi> ok
Comment 4 Debarshi Ray 2012-05-21 15:56:57 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.