After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676187 - Only enable iTunes File Sharing on iOS 3.2 or later
Only enable iTunes File Sharing on iOS 3.2 or later
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afc backend and volume monitor
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-16 18:56 UTC by Martin Szulecki
Modified: 2014-04-16 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afc: Check for iOS >= 3.1.2 to enable house arrest (2.58 KB, patch)
2013-09-18 12:48 UTC, Bastien Nocera 		committed Details | Review

Description Martin Szulecki 2012-05-16 18:56:04 UTC 
iTunes File Sharing requires iOS 3.2 or later and thus we should not try to use the house_arrest service on devices running older iOS versions.

The current code would yield "Unable to mount Documents on iPod touch: Unhandled Lockdown error (-17)" in such a situation.

We expect to only enable this functionality on iOS 3.2 and later and skip it silently for older versions.
Comment 1 Bastien Nocera 2013-09-18 12:48:50 UTC 
Created attachment 255212 [details] [review]
afc: Check for iOS >= 3.1.2 to enable house arrest
Comment 2 Martin Szulecki 2013-10-22 13:24:34 UTC 
Fine, feel free to commit/push (don't have access myself).
Comment 3 Ondrej Holy 2013-10-24 13:34:34 UTC 
(In reply to comment #2)
> Fine, feel free to commit/push (don't have access myself).

Does your message mean that you tested attached patch and it works like expected? If you didn't test it, please do. The patch looks good, however I'm unable to test it properly...
Comment 4 Bastien Nocera 2013-10-24 13:57:11 UTC 
(In reply to comment #3)
> The patch looks good, however I'm
> unable to test it properly...

I don't think any of us are, really :)

iOS 3.x got obsoleted in 2010.
Comment 5 Bastien Nocera 2013-10-24 13:57:35 UTC 
If the patch looks fine to you, please commit.
Comment 6 Martin Szulecki 2013-10-24 14:03:38 UTC 
We still got these old devices and I can verify this patch if it works if you really want that.

However, these old devices do simply have no support for the house_arrest service which wasn't implemented by Apple back then and the patch looks simple enough to correctly handle this.

Thus I don't really think a real test is needed here except warnings/build issues (unless you insist).
Comment 7 Ondrej Holy 2013-10-24 14:49:28 UTC 
Review of attachment 255212 [details] [review]:

It looks good. Not sure if gvfsbackedafc.c doesn't needs also some changes...
Comment 8 Bastien Nocera 2013-10-24 17:16:38 UTC 
(In reply to comment #7)
> Review of attachment 255212 [details] [review]:
> 
> It looks good. Not sure if gvfsbackedafc.c doesn't needs also some changes...

No, because the backend wouldn't be instantiated if the monitor didn't find the device capable.
Comment 9 Ondrej Holy 2014-04-16 11:09:32 UTC 
Comment on attachment 255212 [details] [review]
afc: Check for iOS >= 3.1.2 to enable house arrest

master:
commit 57e9a7f28aac02d8f27ef15d76440a0aa4dd2973

gnome-3-12:
commit 1a43c46737a11ed985549528ef7b342fdc6b35e5