After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676168 - tsdemux: Playback of ts files containing ts packets with adaptation field only and payload start indicator = 1
tsdemux: Playback of ts files containing ts packets with adaptation field onl...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-16 14:29 UTC by Julian Scheel
Modified: 2012-05-18 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't flush on pusi when no payload is contained in ts. (1.18 KB, patch)
2012-05-16 14:29 UTC, Julian Scheel
committed Details | Review

Description Julian Scheel 2012-05-16 14:29:00 UTC
Created attachment 214181 [details] [review]
don't flush on pusi when no payload is contained in ts.

Currently the tsdemuxer assumes that whenever the payload unit start indicator is set on a ts packet it is indicating a new PES packet. Actually this is not true. A new PES is only signalled if the packet contains PES payload.

The attached problem changes the demuxer to handle this correctly and fixes the mentioned streams.

A stream sample to reproduce the issue can be found here:
http://www.jusst.de/files/cablecom-radio.ts

This is captured from a Cablecom IPTV Broadcast in switzerland.
Comment 1 Edward Hervey 2012-05-18 08:21:01 UTC
commit 23bf0b823c454a526b8612ee50c8f2c34bc3c15b
Author: Julian Scheel <julian@jusst.de>
Date:   Wed May 16 16:15:58 2012 +0200

    tsdemux: flush on pusi only for payload packets
    
    Data should not be flushed out of the tsdemux because a payload unit start
    indicator (pusi) is seen in a adaptation only ts packet. If the package contains no
    payload a pusi does not indicate a new PES packet, but PSI information, etc.
    This fixes playback of several TS files which contain ts packets without
    payload but with pusi set to 1.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=676168