After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676131 - avdec_aac should be ranked above faad
avdec_aac should be ranked above faad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.13
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 671544
Blocks:
 
 
Reported: 2012-05-15 21:04 UTC by Nathan Caldwell
Modified: 2014-08-07 07:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nathan Caldwell 2012-05-15 21:04:37 UTC
ffaac supports most everything faad does and is faster and not encumbered with license issues.

The only things that faad supports that ffaac does not is the LD profile, and ER. There are things still missing from ffaac, like; SSR, BSAC, TwinVQ, CELP, and Structured Audio. These same features are missing from faad also.
Comment 1 Tim-Philipp Müller 2012-05-15 21:10:14 UTC
There are unresolved issues around ffdec_aac that would need to be fixed first. And even then extensive testing should be done before switching.
Comment 2 Tim-Philipp Müller 2012-05-15 21:14:54 UTC
And ffdec_aac should ideally be ported to GstAudioDecoder as well.
Comment 3 Tim-Philipp Müller 2012-05-15 21:16:06 UTC
Removing bug #608892 from dependencies list again, since it's probably not so relevant for aac in practice.
Comment 4 Sebastian Dröge (slomo) 2014-01-10 12:18:12 UTC
Ported to GstAudioDecoder since some time. Should we do this now? :)
Comment 5 Tim-Philipp Müller 2014-01-10 13:10:42 UTC
Would've prefered to do this closer to the beginning of the cycle than the end, but ok. It's been marginal for a while now, and I am not aware of any problems with it other than all the issues around latm streams (e.g. bug #679639), but that's independent I guess.
Comment 6 Thibault Saunier 2014-08-06 07:47:00 UTC
Should we do it now then?
Comment 7 Sebastian Dröge (slomo) 2014-08-06 07:56:57 UTC
Go for it :)
Comment 8 Thibault Saunier 2014-08-07 07:26:38 UTC
-bad:

commit 0e67c13d2fd6eb489b0c5996ff53f1e9826548cd
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Wed Aug 6 13:27:04 2014 +0200

    ext:faad: Set rank to SECONDARY as the libav decoder is concidered better
    
    https://bugzilla.gnome.org/show_bug.cgi?id=676131

-libav:

commit dc1e69dbea9687f05779884cd106edfd38d8df1b
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Wed Aug 6 10:14:17 2014 +0200

    avauddec: Bump the rank of avdec_aac so it is used by default
    
    https://bugzilla.gnome.org/show_bug.cgi?id=676131