After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676117 - show network device state reason
show network device state reason
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-15 17:32 UTC by Thomas Bechtold
Modified: 2013-02-11 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network: show device state reasons (Closes:bgo#676117) (42.01 KB, patch)
2012-05-15 21:26 UTC, Thomas Bechtold
committed Details | Review
network: display "device state reason", and remove duplicate code (15.92 KB, patch)
2013-02-04 21:56 UTC, Dan Winship
committed Details | Review

Description Thomas Bechtold 2012-05-15 17:32:05 UTC
NetworkManager offers for every Device a State and a StateReason. Sometimes it's very helpful to know the DeviceStateReason (eg "SIM Pin Required", "SIM Puk required", ...). There's a huge list with DeviceStateReasons in NetworkManager.h (about 40 entries) and i think for some reasons it would be nice to show the reason directly under the device state in the ui.
Comment 1 Thomas Bechtold 2012-05-15 21:26:21 UTC
Created attachment 214156 [details] [review]
network: show device state reasons (Closes:bgo#676117)
Comment 2 Thomas Bechtold 2012-05-15 21:28:38 UTC
(In reply to comment #1)
> Created an attachment (id=214156) [details] [review]
> network: show device state reasons (Closes:bgo#676117)

i edited the network.ui file with glade and glade changed some stuff i didn't want to change. i don't know how to handle this correct. dont use glade? irgnore the changes? fix the changes by hand?
Comment 3 Richard Hughes 2012-05-16 08:57:04 UTC
Applied, after making a few UI changes discussed on IRC. Now the ststus reason is a tooltip on the status label...

commit 1f24b178ac7fdcbe442f5634c0bb04fcb9b979b6
Author: Thomas Bechtold <thomasbechtold@jpberlin.de>
Date:   Mon May 14 08:07:06 2012 +0200

    network: show device state reasons (Closes:bgo#676117)
    
    Signed-off-by: Richard Hughes <richard@hughsie.com>
Comment 4 Bastien Nocera 2012-05-16 09:41:05 UTC
A tooltip isn't any good on touch devices, and the information should really be available in some other way.
Comment 5 Allan Day 2012-11-01 12:04:34 UTC
(In reply to comment #4)
> A tooltip isn't any good on touch devices, and the information should really be
> available in some other way.

Agreed. I would add this information to the status string that is already included in the panel. eg. "Disabled - SIM Pin Required"
Comment 6 Bastien Nocera 2013-01-30 18:45:41 UTC
Comment on attachment 214156 [details] [review]
network: show device state reasons (Closes:bgo#676117)

That patch was already committed.
Comment 7 Dan Winship 2013-02-04 21:56:24 UTC
Created attachment 235168 [details] [review]
network: display "device state reason", and remove duplicate code

For disconnected/unavailable devices, show the localized
NMDeviceStateReason next to the localized NMDeviceState (and not in
the tooltip). Also, move the code to do this into panel-common rather
to save some duplication.
Comment 8 Bastien Nocera 2013-02-11 15:24:33 UTC
Review of attachment 235168 [details] [review]:

Looks good overall

::: panels/network/panel-common.h
@@ +36,3 @@
 const gchar     *panel_vpn_state_to_localized_string           (NMVPNConnectionState type);
+void             panel_set_device_status                       (GtkBuilder *builder,
+                                                                const gchar *label_name,

Line up the parameters if you can.
Comment 9 Dan Winship 2013-02-11 17:49:22 UTC
Attachment 235168 [details] pushed as 15baea4 - network: display "device state reason", and remove duplicate code

> Line up the parameters if you can.

I didn't do that, since it would have made it inconsistent with the
rest of the header.