After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676045 - Add an option to disable building of gtk3 engines
Add an option to disable building of gtk3 engines
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-14 19:56 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2012-05-14 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an option to disable building of gtk3 engines (2.54 KB, patch)
2012-05-14 19:56 UTC, Johan (not receiving bugmail) Dahlin 		needs-work Details | Review
Add an option to disable building of gtk3 engines (2.96 KB, patch)
2012-05-14 20:11 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2012-05-14 19:56:01 UTC 
This makes it possible only build & install without depending on
Gtk+ 3.0 which is useful for shipping Gtk+2.x applications.
Comment 1 Johan (not receiving bugmail) Dahlin 2012-05-14 19:56:03 UTC 
Created attachment 214028 [details] [review]
Add an option to disable building of gtk3 engines
Comment 2 Cosimo Cecchi 2012-05-14 20:03:03 UTC 
Review of attachment 214028 [details] [review]:

Looks good, except the comment below.

::: src/Makefile.am
@@ +4,3 @@
+if GTK3
+engine_LTLIBRARIES += libadwaita.la
+endif

The GTK3 CSS theme still depends on this engine, so you should make the themes/Adwaita/gtk-3.0 directory depend on the conditional too.
Comment 3 Johan (not receiving bugmail) Dahlin 2012-05-14 20:11:59 UTC 
Created attachment 214029 [details] [review]
Add an option to disable building of gtk3 engines

This makes it possible only build & install without depending on
Gtk+ 3.0 which is useful for shipping Gtk+2.x applications.
Comment 4 Johan (not receiving bugmail) Dahlin 2012-05-14 20:16:09 UTC 
Attachment 214029 [details] pushed as 38c2ad8 - Add an option to disable building of gtk3 engines