After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676036 - Bookmarks gone after update to 3.4.2 (due to #675393)
Bookmarks gone after update to 3.4.2 (due to #675393)
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other All
: Normal major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-14 17:19 UTC by Jasper Lievisse Adriaanse
Modified: 2012-05-14 18:12 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4



Description Jasper Lievisse Adriaanse 2012-05-14 17:19:42 UTC
After updating gnome-panel to 3.4.2 my bookmarks which used to be displayed in the Places menu are gone. This is due to the fact that (gtk_check_version (3, 5, 1)) appears to return a non-falsy value on my gtk 3.4.3 installation, and thus the first branch is taken...but that's only meant for gtk 3.5.1.

For now I've made it a compile time check, but that doesn't feel right given the commit message. Any idea what's going on with gtk_check_version() here?
Comment 1 Vincent Untz 2012-05-14 18:05:08 UTC
Doh, it's my fault -- I was assuming gtk_check_version() return a boolean, but it returns a string describing the mismatch... So the check is reversed.
Comment 2 Vincent Untz 2012-05-14 18:09:12 UTC
Fixed in git, will release 3.4.2.1. Sorry for the mess :-)
Comment 3 Jasper Lievisse Adriaanse 2012-05-14 18:12:33 UTC
Thanks for the quick fix! :)