After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676021 - Use tp-glib version macros
Use tp-glib version macros
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal enhancement
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-14 11:01 UTC by Guillaume Desmottes
Modified: 2012-05-22 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use tp-glib API version macros (1.05 KB, patch)
2012-05-14 11:02 UTC, Guillaume Desmottes 		needs-work Details | Review
Use tp-glib API version macros (1.28 KB, patch)
2012-05-15 06:20 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-05-14 11:01:59 UTC 
.
Comment 1 Guillaume Desmottes 2012-05-14 11:02:16 UTC 
Created attachment 213991 [details] [review]
Use tp-glib API version macros
Comment 2 Philip Withnall 2012-05-14 23:04:04 UTC 
Review of attachment 213991 [details] [review]:

Unless I’m mistaken, I don’t think this’ll have any effect, since tpf-persona-store.vala and friends don’t generate “#include <config.h>”. It might be better to add the #defines to a TP_GLIB_CPPFLAGS automake variable and use that in backends/telepathy[/lib]/Makefile.am instead.
Comment 3 Guillaume Desmottes 2012-05-15 06:20:28 UTC 
Created attachment 214058 [details] [review]
Use tp-glib API version macros
Comment 4 Philip Withnall 2012-05-15 15:28:25 UTC 
Review of attachment 214058 [details] [review]:

Looks good to me. Please commit.

(What we really need, though, is some variant of PKG_CHECK_MODULES which does this automatically. That would be nice.)
Comment 5 Guillaume Desmottes 2012-05-15 15:56:10 UTC 
Attachment 214058 [details] pushed as 5a62b1b - Use tp-glib API version macros
Comment 6 Xavier Claessens 2012-05-22 15:23:07 UTC 
Note that this is pretty much useless since deprecations should be catched at valac level, not gcc.