After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675955 - Sheet style issues
Sheet style issues
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-05-12 20:37 UTC by Morten Welinder
Modified: 2012-05-17 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2012-05-12 20:37:45 UTC 
1. gnm_style_hash was a poor quality hash.
[recently fixed]

2. gnm_style_hash and gnm_style_equal should only look at set elements.
[recently fixed]

3. GnmSheetStyleData::style_hash has problems with removing elements.
   We can change elements so they become equal, but when we remove
   an element from the hash it's anyone's guess what element we are
   removing.  Probably not good.

   style_hash should become a map from style-hash-value to a GSList of
   styles with that hash.  (I.e., we should handle hashing and
   collisions manually leaving the resizing to glib.)
Comment 1 Morten Welinder 2012-05-12 23:48:06 UTC 
4. cell_tile_optimize uses gnm_style_equal, but should now use gnm_style_eq
   (aka pointer comparison).  That's probably true for sample_styles and
   verify_styles too.  Maybe sheet_style_get_range.
Comment 2 Morten Welinder 2012-05-14 14:31:08 UTC 
#4 fixed.
Comment 3 Morten Welinder 2012-05-16 18:49:09 UTC 
#3 fixed.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Morten Welinder 2012-05-17 17:51:07 UTC 
5. When a style is linked into a different sheet, the dependents embedded
   in, say, validation need to be updated.

Fixed.