After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675915 - annotationparser: Don't be too greedy when reading tags
annotationparser: Don't be too greedy when reading tags
Status: RESOLVED DUPLICATE of bug 674658
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-05-11 23:16 UTC by Ray Strode [halfline]
Modified: 2015-02-07 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
annotationparser: Don't be too greedy when reading tags (1.42 KB, patch)
2012-05-11 23:16 UTC, Ray Strode [halfline] 		reviewed Details | Review
regress: test tags above description parsing (3.10 KB, patch)
2012-05-15 15:31 UTC, Ray Strode [halfline] 		none Details | Review

Description Ray Strode [halfline] 2012-05-11 23:16:50 UTC 
farstream has annotations of the form:

/**
 * FsSession:codecs-without-config:
 *
 * Type: GLib.List(FsCodec)
 * Transfer: full
 *
 * This is the same list of codecs as #FsSession:codecs
 * without....

g-ir-scanner was attributing the description to the Transfer tag.

This commit improves annotationparser's description block detection
code, to work when there are tags right before the description.
Comment 1 Ray Strode [halfline] 2012-05-11 23:16:52 UTC 
Created attachment 213894 [details] [review]
annotationparser: Don't be too greedy when reading tags
Comment 2 Colin Walters 2012-05-15 14:03:14 UTC 
Review of attachment 213894 [details] [review]:

The main concern I have about this is we need to "do what gtk-doc does".  That was a major motivation behind dieterv's reworking of the parser. 

So I assume we supported this before his reworking, but we don't anymore, which is a regression from farstream's perspective.  But it's worth considering whether the right fix here is for them to move the block annotations down below the description.

Regardless though, this should get a regression test in tests/scanner/regress.h.
Comment 3 Ray Strode [halfline] 2012-05-15 15:31:32 UTC 
Created attachment 214123 [details] [review]
regress: test tags above description parsing
Comment 4 Ray Strode [halfline] 2012-05-15 17:31:45 UTC 
dieterv pointed out this is a dupe on irc.

*** This bug has been marked as a duplicate of bug 674658 ***
Comment 5 André Klapper 2015-02-07 16:51:00 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]