GNOME Bugzilla – Bug 675910
Trouble with gtk-update-icon-cache hooks
Last modified: 2012-05-14 19:32:43 UTC
http://git.gnome.org/browse/gnome-themes-standard/commit/?id=e0841e2c added gtk-update-icon-cache hooks for 'make install' and 'make uninstall', but this has some issues: - the caches are only generated for the HighContrast theme, but missing for the rest of the themes; - the caches are generated even if DESTDIR is set, which can cause trouble for binary distros Binary distros usually don't include cache files in binary packages, but instead regenerate them after package installation at the end user's machine. Because of that, they don't want the icon cache regeneration during build time. When DESTDIR is set, it's a good indication that the cache files should be left alone. Evince is a good example how to do that: http://git.gnome.org/browse/evince/tree/data/Makefile.am?id=3.4.0#n67
Created attachment 213890 [details] [review] HighContrast: Don't update the icon cache None of the other themes in gnome-themes-standard besides HighContrast run gtk-update-icon-cache, so remove it from this theme as well for consistency.
Created attachment 214009 [details] [review] Add hooks for updating gtk icon cache An alternative patch that adds gtk-update-icon-cache hooks to all the themes, and fixes up the existing one in HighContrast to skip cache rebuilding when DESTDIR is set.
Attachment 214009 [details] pushed as 00b7f4a - Add hooks for updating gtk icon cache Thanks, pushed to master and gnome-3-4. Will be in today's 3.4.2.