GNOME Bugzilla – Bug 675902
indicate if headphones are plugged in
Last modified: 2012-12-08 18:40:59 UTC
It might be nice to indicate whether headphones are plugged in in the sound menu. This is particularly useful if you are changing the volume because you can't hear something and don't realize that headphones are plugged in. It would also be nice to maintain different volume level status for each output device. So when I plug in phones it goes back to non-ear-bleedingly loud. Also see bug 675901.
The different volume levels are maintained by PulseAudio now, so the only thing missing here is the icon on the side.
Created attachment 226761 [details] [review] Update copy-pasted libgnome-volume-control Taken from gnome-control-center, has new API to support PulseAudio 2.0
Created attachment 226762 [details] [review] GvcMixerStream: expose form factor from PulseAudio
Created attachment 226763 [details] [review] Gvc: make GvcMixerStreamPort a boxed type It's a prerequisite for accessing it from JS
Created attachment 226764 [details] [review] VolumeMenu: show headphone icon when headphones are plugged in This will show the user where sound will come out, and should help if he forgets them plugged, or forgets to plug them before playing music.
Review of attachment 226761 [details] [review]: Sure.
Review of attachment 226762 [details] [review]: Are you going to upstream these changes?
Review of attachment 226764 [details] [review]: Sure.
(In reply to comment #7) > Review of attachment 226762 [details] [review]: > > Are you going to upstream these changes? This is what I'm going to do: https://mail.gnome.org/archives/gnome-shell-list/2012-October/msg00037.html
(In reply to comment #7) > Review of attachment 226762 [details] [review]: > > Are you going to upstream these changes? The libgnome-volume-control submodule work is now used by gnome-settings-daemon and gnome-control-center. Would you mind reviewing these patches, so that I can switch to libgnome-volume-control at once? I know I'm listed as maintainer of that, but a second pair of eyes is always better. Also, it is a bit painful to carry this patch, since I'm replacing a directory with a submodule, and git doesn't like that at all.
Review of attachment 226762 [details] [review]: ::: src/gvc/gvc-mixer-stream.c @@ +442,3 @@ + + g_free (stream->priv->form_factor); + stream->priv->form_factor = g_strdup (form_factor); This is missing a matching g_free in finalize or dispose
Review of attachment 226763 [details] [review]: Looks good to me
Pushed as 784b04b191022b3b4e349ed123a2976ccb4007bb.
Looks like this needs srcdir != builddir fixing: http://ostree.gnome.org/work/tasks/gnomeos-3.8-build/2012.2204/log
I just fixed it; was a bug in the gvc introspection build rules.