After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675894 - remove dead code
remove dead code
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-11 15:59 UTC by William Jon McCann
Modified: 2012-05-11 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove unused gtk accel map code (2.57 KB, patch)
2012-05-11 16:03 UTC, William Jon McCann
committed Details | Review
Remove dead code (2.18 KB, patch)
2012-05-11 16:03 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-05-11 15:59:23 UTC
There is some #if 0 code that we should just remove. We have git for historical analysis so we don't need to keep code around that isn't used. I was going to file a bug about removing the gtk accel maps even if it wasn't disabled.
Comment 1 William Jon McCann 2012-05-11 16:03:37 UTC
Created attachment 213878 [details] [review]
Remove unused gtk accel map code
Comment 2 William Jon McCann 2012-05-11 16:03:39 UTC
Created attachment 213879 [details] [review]
Remove dead code
Comment 3 Robert Ancell 2012-05-11 16:39:11 UTC
Review of attachment 213878 [details] [review]:

We love dead code removal :)  Thanks!
Comment 4 Robert Ancell 2012-05-11 16:39:24 UTC
Review of attachment 213879 [details] [review]:

Ditto