After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675872 - Constification of libwacom_get_styli() returned value
Constification of libwacom_get_styli() returned value
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-11 12:50 UTC by Olivier Fourdan
Modified: 2012-05-17 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (trivial) (837 bytes, patch)
2012-05-11 12:50 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2012-05-11 12:50:12 UTC 
Created attachment 213866 [details] [review]
Proposed patch (trivial)

A recent API change in libwacom (commit 715ac982 [1]) changed the returned value from libwacom_get_styli() to const int, causing a warning in g-s-d at build time:

  gsd-wacom-device.c:1135:7: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]

Trivial patch attached.

[1] http://linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/libwacom;a=commit;h=715ac982
Comment 1 Olivier Fourdan 2012-05-11 12:50:57 UTC 
Note: same needs to be done in gnome-control-center, with "make update-from-gsd"
Comment 2 Bastien Nocera 2012-05-17 17:29:47 UTC 
(In reply to comment #0)
> Created an attachment (id=213866) [details] [review]
> Proposed patch (trivial)
> 
> A recent API change in libwacom (commit 715ac982 [1]) changed the returned
> value from libwacom_get_styli() to const int, causing a warning in g-s-d at
> build time:
> 
>   gsd-wacom-device.c:1135:7: warning: assignment discards 'const' qualifier
> from pointer target type [enabled by default]

If the change is new, you need to bump the requirements in configure.ac so that we don't get warnings reported with old versions.