GNOME Bugzilla – Bug 675822
[Patchreport extension] Display filesize and author of patches
Last modified: 2015-02-10 19:01:37 UTC
GNOME's extension to list patches for a product defines the format of each entry (patch) on https://bugzilla.gnome.org/page.cgi?id=patchreport.html&product=evince&patch-status=none here: http://bazaar.launchpad.net/~bgo-maintainers/bugzilla.gnome.org/3.4/view/head:/extensions/patch-report/template/en/default/pages/patchreport.html.tmpl#L45 patchreport.html also list the age of every patch. It is calculated here: http://bazaar.launchpad.net/~bgo-maintainers/bugzilla.gnome.org/3.4/view/head:/extensions/patch-report/lib/PatchReport/Hooks.pm#l125 I would like to see the filesize listed next to the age of a patch, as one entry point (low hanging fruit) to find and review small patches in products that have a big patch backlog. The filesize of a patch (attachment.datasize) is displayed here: http://bazaar.launchpad.net/~bgo-maintainers/bugzilla.gnome.org/3.4/view/head:/template/en/default/attachment/edit.html.tmpl#L202
PS: It is currently (4.3) not possible to run a query based on the filesize of attachments that are patches either.
Meh, of course not stored in the attachments table; probably somehow accessible via .datasize in Attachment.pm but I don't have enough skills.
I'm going to attach a patch here that I would like to get in. My naive thought is that displaying the size of patches on patchreport.html might motivate some folks to at least review smaller patches more often. Same for showing "known" authors, but that might backfire - could also trigger judgement and ignoring patches by unknown authors (with unknown quality). As author, the email address is displayed (obfuscated if logged out). I tried displaying the realname, but that field is optional and when not set for an account the string is simply empty. Smaller change: I have removed showing the Attachment ID (srsly, who cares?). Furthermore, I have no idea either about the performance implications of this patches, making an INNER JOIN on two more tables. I would appreciate input and opinions. Or maybe I should even bring this to d-d-l where maintainers are; wondering how many people use that page at all...
Created attachment 294763 [details] [review] Show author and size of patches
Created attachment 294764 [details] Screenshot
No feedback for a week so I committed this into git master: https://git.gnome.org/browse/bugzilla-gnome-org-customizations/commit/?id=364d9216c8698d7ec75f70fd9e6985736884fdce
Ah. I should only close once this is live, after 4.4
This is live now, closing as fixed.