After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675807 - use new TpTextChannel chat state API
use new TpTextChannel chat state API
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-10 13:38 UTC by Guillaume Desmottes
Modified: 2012-05-10 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
chat: use contact-chat-state-changed signal (2.28 KB, patch)
2012-05-10 13:48 UTC, Guillaume Desmottes 		committed Details | Review
tp-chat: remove chat-state-changed-empathy signal (3.06 KB, patch)
2012-05-10 13:48 UTC, Guillaume Desmottes 		committed Details | Review
client-factory: request TP_TEXT_CHANNEL_FEATURE_CHAT_STATES (1009 bytes, patch)
2012-05-10 13:48 UTC, Guillaume Desmottes 		committed Details | Review
tp-chat: use tp_text_channel_get_chat_state() (934 bytes, patch)
2012-05-10 13:48 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-05-10 13:38:04 UTC 
.
Comment 1 Guillaume Desmottes 2012-05-10 13:48:27 UTC 
Created attachment 213805 [details] [review]
chat: use contact-chat-state-changed signal

Now that we have a signal giving us a prepared TpContact there is no need to
use the empathy variant as we can easily create the EmpathyContact directly.
Comment 2 Guillaume Desmottes 2012-05-10 13:48:30 UTC 
Created attachment 213806 [details] [review]
tp-chat: remove chat-state-changed-empathy signal
Comment 3 Guillaume Desmottes 2012-05-10 13:48:33 UTC 
Created attachment 213807 [details] [review]
client-factory: request TP_TEXT_CHANNEL_FEATURE_CHAT_STATES

TP_CHANNEL_FEATURE_CHAT_STATES has been deprecated.
Comment 4 Guillaume Desmottes 2012-05-10 13:48:35 UTC 
Created attachment 213808 [details] [review]
tp-chat: use tp_text_channel_get_chat_state()
Comment 5 Xavier Claessens 2012-05-10 13:55:39 UTC 
+1
Comment 6 Guillaume Desmottes 2012-05-10 13:58:49 UTC 
Attachment 213805 [details] pushed as 2d4e2fb - chat: use contact-chat-state-changed signal
Attachment 213806 [details] pushed as 3632d39 - tp-chat: remove chat-state-changed-empathy signal
Attachment 213807 [details] pushed as 9c18d54 - client-factory: request TP_TEXT_CHANNEL_FEATURE_CHAT_STATES
Attachment 213808 [details] pushed as 27be4b9 - tp-chat: use tp_text_channel_get_chat_state()