GNOME Bugzilla – Bug 675753
[PATCH] Remove gnome-python dependency
Last modified: 2013-05-10 09:53:32 UTC
Created attachment 213736 [details] [review] Remove gnome-python dependency This patch removes libgnomeui/libgnomeui dependency, which is a deprecated library[1], by removing the usage of gnome-python bindings. The only drawback is that the terminal application is no longer configurable, it's hard-coded to gnome-terminal. [1] https://live.gnome.org/ProjectRidley
(In reply to comment #0) > Created an attachment (id=213736) [details] [review] > Remove gnome-python dependency > > This patch removes libgnomeui/libgnomeui dependency, which is a deprecated > library[1], by removing the usage of gnome-python bindings. Great! Nice work, thanks. > The only drawback is that the terminal application is no longer configurable, > it's hard-coded to gnome-terminal. > > [1] https://live.gnome.org/ProjectRidley This is quite important, but its replacement xdg-terminal is coming up in xdg-utils: http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-terminal I would suggest implementing it using xdg-terminal now, and wait with a release at least until a stable version of xdg-utils with it included is released. xdg-terminal still seem to have some serious issues. I am using a custom script at the moment. - Gaute
xdg-terminal is not distributed in the latest 1.1.0-rc1 release of xdg-utils. Are you sure that it will be distributed in the next release?
(In reply to comment #2) > xdg-terminal is not distributed in the latest 1.1.0-rc1 release of xdg-utils. > Are you sure that it will be distributed in the next release? No. But hard coding gnome-terminal is not really an option (it would for instance not work for me), according to ProjectRidley xdg-terminal will be the replacement for this functionality in libgnome. I will try to figure out if xdg-terminal is on its way any time soon, but it seems to have received some work in the latest commits. If it continues to be on standby for another N years we would have to find another solution. - Gaute
I don't see any activity on xdg-terminal: http://cgit.freedesktop.org/xdg/xdg-utils/log/scripts/xdg-terminal An alternative solution is that gsettings-desktop-schemas contains a org.gnome.desktop.default-applications.terminal schema to store the default terminal application and its exec argument. So gnome-schedule could read these settings simply with the following commands: gsettings get org.gnome.desktop.default-applications.terminal exec gsettings get org.gnome.desktop.default-applications.terminal exec-arg
(In reply to comment #4) > I don't see any activity on xdg-terminal: > > http://cgit.freedesktop.org/xdg/xdg-utils/log/scripts/xdg-terminal > > An alternative solution is that gsettings-desktop-schemas contains a > org.gnome.desktop.default-applications.terminal schema to store the default > terminal application and its exec argument. So gnome-schedule could read these > settings simply with the following commands: > > gsettings get org.gnome.desktop.default-applications.terminal exec > gsettings get org.gnome.desktop.default-applications.terminal exec-arg Is that not exactly what gnome-python does?
No, gnome-python stores similar settings from GConf, and it's deprecated a long time ago.
(In reply to comment #6) > No, gnome-python stores similar settings from GConf, and it's deprecated a long > time ago. Alright, then this could be a good solution! Do you want to update the patch?
Merged and updated to use gsettings. Thanks.