After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675599 - dshowvideosink: Fix compilation on x64 platforms
dshowvideosink: Fix compilation on x64 platforms
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-07 10:51 UTC by Andoni Morales
Modified: 2012-05-07 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-dshowvideosink-Fix-compilation-on-x64-platforms.patch (766 bytes, patch)
2012-05-07 10:51 UTC, Andoni Morales 		committed Details | Review

Description Andoni Morales 2012-05-07 10:51:38 UTC 
Created attachment 213572 [details] [review]
0001-dshowvideosink-Fix-compilation-on-x64-platforms.patch

In x64 platforms, GWL_WNDPROC is defined as GWLP_WNDPROC
Comment 1 Sebastian Dröge (slomo) 2012-05-07 10:53:54 UTC 
commit 30c83758c4347b8de5e02fcb4f769db29ebcb154
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Wed May 2 07:56:00 2012 -0700

    dshowvideosink: Fix compilation on x64 platforms
Comment 2 Raimo Järvi 2012-05-07 16:23:05 UTC 
Why not use GWLP_WNDPROC instead of GWL_WNDPROC? I don't think SetWindowLong / GetWindowLong will work on x64 anyway.
Comment 3 Andoni Morales 2012-05-07 16:56:42 UTC 
You mean using GWLP_WNDPROC on both architectures?
This patch has been tested in both win32 and x64
Comment 4 Raimo Järvi 2012-05-07 17:06:39 UTC 
(In reply to comment #3)
> You mean using GWLP_WNDPROC on both architectures?

Yes, why not?

> This patch has been tested in both win32 and x64

http://msdn.microsoft.com/en-us/library/windows/desktop/ms633591%28v=vs.85%29.aspx