GNOME Bugzilla – Bug 675597
Consider removing EmpathyTpContactFactory
Last modified: 2012-05-15 11:24:51 UTC
Now that tp-glib is giving us prepared TpContact objects, we should consider removing EmpathyTpContactFactory.
Created attachment 213581 [details] [review] tp-contact-factory: remove unused methods
Created attachment 213582 [details] [review] ft-handler: create EmpathyContact from TpContact
Created attachment 213583 [details] [review] tp-chat: stop using the contact factory when building message Messages are now synchronously proccessed so we don't have to keep an internal queue of messages being prepared. We also need to complete the preparation of the EmpathyTpChat feature in idle as it's now prepared synchronously as well.
Created attachment 213584 [details] [review] event-manager: factor out approve_channel_*() functions This approve function is way to big, let's split it.
Created attachment 213585 [details] [review] approve_call_channel: stop using the contact factory
Created attachment 213586 [details] [review] approve_ft_channel: stop using the contact factory
Looks all good
Attachment 213581 [details] pushed as c33d6ea - tp-contact-factory: remove unused methods Attachment 213582 [details] pushed as 5673bdb - ft-handler: create EmpathyContact from TpContact Attachment 213583 [details] pushed as 50241f7 - tp-chat: stop using the contact factory when building message Attachment 213584 [details] pushed as aaf3c94 - event-manager: factor out approve_channel_*() functions Attachment 213585 [details] pushed as 89c1b2f - approve_call_channel: stop using the contact factory Attachment 213586 [details] pushed as 09ac300 - approve_ft_channel: stop using the contact factory
Remaining use of this factory: empathy_tp_contact_factory_get_from_handle ----------------------------------------------------------------------- tp-chat: will go away once https://bugs.freedesktop.org/show_bug.cgi?id=49215 has been released. empathy_tp_contact_factory_get_from_id --------------------------------------------------------------- empathy-contact-search-dialog: to get an EmpathyContact from a contact identifier received from TpContactSearchResult. libempathy-gtk/empathy-contact-widget.c: to get an EmpathyContact from the identifier enterer by user when adding a contact.
Created attachment 213787 [details] [review] add empathy_client_factory_dup_contact_by_id_async()
Created attachment 213788 [details] [review] contact-search-dialog: use empathy_client_factory_dup_contact_by_id_async()
Attachment 213787 [details] pushed as 1b678e4 - add empathy_client_factory_dup_contact_by_id_async() Attachment 213788 [details] pushed as cf9caca - contact-search-dialog: use empathy_client_factory_dup_contact_by_id_async()
Created attachment 214078 [details] [review] contact-widget: use empathy_client_factory_dup_contact_by_id_async()
Created attachment 214079 [details] [review] remove unused tp-contact-factory includes
Created attachment 214080 [details] [review] remove tp-contact-factory
Created attachment 214081 [details] [review] Warn on tp-glib 0.20 deprecations Best to catch them sooner than later.
Attachment 214078 [details] pushed as 4180f9c - contact-widget: use empathy_client_factory_dup_contact_by_id_async() Attachment 214079 [details] pushed as 885ab0e - remove unused tp-contact-factory includes Attachment 214080 [details] pushed as 66aa8b1 - remove tp-contact-factory Attachment 214081 [details] pushed as fe79be1 - Warn on tp-glib 0.20 deprecations