After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675597 - Consider removing EmpathyTpContactFactory
Consider removing EmpathyTpContactFactory
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-07 09:51 UTC by Guillaume Desmottes
Modified: 2012-05-15 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tp-contact-factory: remove unused methods (7.94 KB, patch)
2012-05-07 12:25 UTC, Guillaume Desmottes
committed Details | Review
ft-handler: create EmpathyContact from TpContact (2.41 KB, patch)
2012-05-07 12:25 UTC, Guillaume Desmottes
committed Details | Review
tp-chat: stop using the contact factory when building message (5.21 KB, patch)
2012-05-07 12:25 UTC, Guillaume Desmottes
committed Details | Review
event-manager: factor out approve_channel_*() functions (9.13 KB, patch)
2012-05-07 12:25 UTC, Guillaume Desmottes
committed Details | Review
approve_call_channel: stop using the contact factory (4.88 KB, patch)
2012-05-07 12:25 UTC, Guillaume Desmottes
committed Details | Review
approve_ft_channel: stop using the contact factory (3.53 KB, patch)
2012-05-07 12:25 UTC, Guillaume Desmottes
committed Details | Review
add empathy_client_factory_dup_contact_by_id_async() (3.41 KB, patch)
2012-05-10 09:36 UTC, Guillaume Desmottes
committed Details | Review
contact-search-dialog: use empathy_client_factory_dup_contact_by_id_async() (4.60 KB, patch)
2012-05-10 09:37 UTC, Guillaume Desmottes
committed Details | Review
contact-widget: use empathy_client_factory_dup_contact_by_id_async() (2.66 KB, patch)
2012-05-15 11:17 UTC, Guillaume Desmottes
committed Details | Review
remove unused tp-contact-factory includes (5.52 KB, patch)
2012-05-15 11:17 UTC, Guillaume Desmottes
committed Details | Review
remove tp-contact-factory (9.50 KB, patch)
2012-05-15 11:17 UTC, Guillaume Desmottes
committed Details | Review
Warn on tp-glib 0.20 deprecations (901 bytes, patch)
2012-05-15 11:17 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-05-07 09:51:45 UTC
Now that tp-glib is giving us prepared TpContact objects, we should consider removing EmpathyTpContactFactory.
Comment 1 Guillaume Desmottes 2012-05-07 12:25:02 UTC
Created attachment 213581 [details] [review]
tp-contact-factory: remove unused methods
Comment 2 Guillaume Desmottes 2012-05-07 12:25:04 UTC
Created attachment 213582 [details] [review]
ft-handler: create EmpathyContact from TpContact
Comment 3 Guillaume Desmottes 2012-05-07 12:25:07 UTC
Created attachment 213583 [details] [review]
tp-chat: stop using the contact factory when building message

Messages are now synchronously proccessed so we don't have to keep an internal
queue of messages being prepared.
We also need to complete the preparation of the EmpathyTpChat feature in idle
as it's now prepared synchronously as well.
Comment 4 Guillaume Desmottes 2012-05-07 12:25:10 UTC
Created attachment 213584 [details] [review]
event-manager: factor out approve_channel_*() functions

This approve function is way to big, let's split it.
Comment 5 Guillaume Desmottes 2012-05-07 12:25:13 UTC
Created attachment 213585 [details] [review]
approve_call_channel: stop using the contact factory
Comment 6 Guillaume Desmottes 2012-05-07 12:25:15 UTC
Created attachment 213586 [details] [review]
approve_ft_channel: stop using the contact factory
Comment 7 Xavier Claessens 2012-05-08 06:48:02 UTC
Looks all good
Comment 8 Guillaume Desmottes 2012-05-08 07:13:34 UTC
Attachment 213581 [details] pushed as c33d6ea - tp-contact-factory: remove unused methods
Attachment 213582 [details] pushed as 5673bdb - ft-handler: create EmpathyContact from TpContact
Attachment 213583 [details] pushed as 50241f7 - tp-chat: stop using the contact factory when building message
Attachment 213584 [details] pushed as aaf3c94 - event-manager: factor out approve_channel_*() functions
Attachment 213585 [details] pushed as 89c1b2f - approve_call_channel: stop using the contact factory
Attachment 213586 [details] pushed as 09ac300 - approve_ft_channel: stop using the contact factory
Comment 9 Guillaume Desmottes 2012-05-08 07:48:19 UTC
Remaining use of this factory:

empathy_tp_contact_factory_get_from_handle
-----------------------------------------------------------------------

tp-chat: will go away once https://bugs.freedesktop.org/show_bug.cgi?id=49215 has been released.

empathy_tp_contact_factory_get_from_id
---------------------------------------------------------------

empathy-contact-search-dialog: to get an EmpathyContact from a contact identifier received from TpContactSearchResult.

libempathy-gtk/empathy-contact-widget.c:  to get an EmpathyContact from the identifier enterer by user when adding a contact.
Comment 10 Guillaume Desmottes 2012-05-10 09:36:58 UTC
Created attachment 213787 [details] [review]
add empathy_client_factory_dup_contact_by_id_async()
Comment 11 Guillaume Desmottes 2012-05-10 09:37:01 UTC
Created attachment 213788 [details] [review]
contact-search-dialog: use empathy_client_factory_dup_contact_by_id_async()
Comment 12 Guillaume Desmottes 2012-05-10 09:43:47 UTC
Attachment 213787 [details] pushed as 1b678e4 - add empathy_client_factory_dup_contact_by_id_async()
Attachment 213788 [details] pushed as cf9caca - contact-search-dialog: use empathy_client_factory_dup_contact_by_id_async()
Comment 13 Guillaume Desmottes 2012-05-15 11:17:15 UTC
Created attachment 214078 [details] [review]
contact-widget: use empathy_client_factory_dup_contact_by_id_async()
Comment 14 Guillaume Desmottes 2012-05-15 11:17:18 UTC
Created attachment 214079 [details] [review]
remove unused tp-contact-factory includes
Comment 15 Guillaume Desmottes 2012-05-15 11:17:21 UTC
Created attachment 214080 [details] [review]
remove tp-contact-factory
Comment 16 Guillaume Desmottes 2012-05-15 11:17:24 UTC
Created attachment 214081 [details] [review]
Warn on tp-glib 0.20 deprecations

Best to catch them sooner than later.
Comment 17 Guillaume Desmottes 2012-05-15 11:24:40 UTC
Attachment 214078 [details] pushed as 4180f9c - contact-widget: use empathy_client_factory_dup_contact_by_id_async()
Attachment 214079 [details] pushed as 885ab0e - remove unused tp-contact-factory includes
Attachment 214080 [details] pushed as 66aa8b1 - remove tp-contact-factory
Attachment 214081 [details] pushed as fe79be1 - Warn on tp-glib 0.20 deprecations