After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675477 - lamemp3enc: add a specific default MP3 preset
lamemp3enc: add a specific default MP3 preset
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
unspecified
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-04 21:56 UTC by Conor Curran
Modified: 2015-06-13 22:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Conor Curran 2012-05-04 21:56:31 UTC
Please ship the attached MP3 preset. 

Contents:

[_presets_]
element-name=GstLameMP3Enc
version=0.10.36

[12:04-default]
name=lamemp3enc
perfect-timestamp=false
hard-resync=false
tolerance=40000000
target=Quality
bitrate=192
cbr=false
quality=2
encoding-engine-quality=Standard
mono=false

The variable bitrate settings as can be seen is at quality level 2 which should average at around 192 kbit/sec. IMO I think in this day and age with internet speeds attainable today that is acceptable.
Comment 1 Conor Curran 2012-05-04 23:44:42 UTC
According to one of our users including 
perfect-timestamp=true in the above .prs makes for better performance across all devices.
Comment 2 Sebastian Dröge (slomo) 2012-05-09 07:33:41 UTC
If you set quality as target you don't have to set a bitrate at all, it has no effect.

What are the reasons for setting hard-resync and tolerance in the preset?

What's the improved performance that was reported by one of your users by using perfect-timestamps=true?
Comment 3 Sebastian Dröge (slomo) 2012-05-09 07:34:09 UTC
Also, could you attach a "git format-patch" style patch against gst-plugins-ugly for this?
Comment 4 Doug McMahon 2012-05-16 06:33:46 UTC
> What's the improved performance that was reported by one of your users by using
perfect-timestamps=true?

As it turns out none really. It first appeared that it allowed RB mp3 encodes to show accurate times in some other players like audacious, more testing showed almost no RB mp3 encodes will show proper track times in most players inc. RB itself!

Ironically only banshee will show the correct track time from RB mp3 encodes
Comment 5 Sebastian Dröge (slomo) 2012-05-16 06:42:22 UTC
Is xingmux used after lamemp3enc?
Comment 6 Doug McMahon 2012-06-21 01:37:13 UTC
What seems to be the issue here with getting done?
RB 2.97 in Ubuntu has the custom settings option for both mp3 & vorbis. Selecting it creates the proper ~/.gstreamer-0.10/presets/*.prs's 
Only one small issue - 
There is no "preset=<whatever> line in /usr/share/rhythmbox/rhythmbox.gep so the whole deal is currently worthless!

requested for ubuntu was
preset=rhythmbox-custom-settings.

It really shouldn't be this hard to help your users out.
Comment 7 Tim-Philipp Müller 2012-10-17 13:46:04 UTC
Note that applications can just ship their own GStreamer presets in addition to what we ship upstream, and then use gst_preset_set_app_dir() to point GStreamer to those presets. That way they don't have to wait for us to add something.
Comment 8 Alexandre Franke 2015-06-13 22:42:32 UTC
It seems there's no reason to keep this open since the presets can be shipped by apps. Closing this as there's no movement anyway.