GNOME Bugzilla – Bug 675471
add an app menu with a help item in it
Last modified: 2012-09-12 09:26:10 UTC
We should probably add an app menu with Help in it.
Agree.
Just Help and no Quit? Also: should the launched help page always be the same or should it depend on the currently active settings panel?
Quit should always be there IMO
Yeah we have Quit so I was ignoring that :)
OK, so what about the second question?
I guess it might be interesting to provide a hint to the help system about where the user is coming from. I think it is up to them to decide if it should be tuned to that context or not. Probably want to ask them.
Created attachment 213692 [details] [review] shell: Make sure the "active-panel" property is updated The (currently unused) cc_shell_get_active_panel() method is useless unless "active-panel" is actually updated correctly.
Created attachment 213693 [details] [review] cc-panel: Add get_help_uri() vfunc We want to allow panels to point to a specific help page, so add a vfunc for that.
Created attachment 213694 [details] [review] panels: Implement get_help_uri() if applicable Add a get_help_uri() implementation to all panels but info and wacom.
Created attachment 213695 [details] [review] shell: Add application menu Add a simple application menu containing just "Help" and "Quit".
(In reply to comment #6) > I guess it might be interesting to provide a hint to the help system about > where the user is coming from. I think it is up to them to decide if it should > be tuned to that context or not. I don't think we can currently do hints, so I made help unconditionally depend on context. We can still revisit that as necessary. (If we decide that a "fixed" help item is better, only the last patch is needed (with some simplifications))
Review of attachment 213692 [details] [review]: Could you please split the changes to pass the object itself rather than its private member? Also, the rest of the patch doesn't apply now.
Review of attachment 213693 [details] [review]: ::: shell/cc-panel.c @@ +255,3 @@ + if (class->get_help_uri) + return class->get_help_uri (panel); +g_warning ("wort mit x ..."); Interesting.
Review of attachment 213694 [details] [review]: I'd prefer one patch per panel instead, but the code itself is fine.
Review of attachment 213695 [details] [review]: ::: shell/control-center.c @@ +190,3 @@ + GtkWidget *window = cc_shell_get_toplevel (CC_SHELL (shell)); + + gtk_widget_destroy (window); We unref it when handling Ctrl+Q.
*** Bug 653591 has been marked as a duplicate of this bug. ***
(In reply to comment #12) > Could you please split the changes to pass the object itself rather than its > private member? Sure. (In reply to comment #13) > +g_warning ("wort mit x ..."); > > Interesting. Woops, sorry. (In reply to comment #14) > I'd prefer one patch per panel instead, but the code itself is fine. It felt shamelessly boosting my commit stats, but sure :-)
Created attachment 214340 [details] [review] shell: Pass the object to show_overview_page(), not its private We will need it to update the "active-panel" property properly.
Created attachment 214341 [details] [review] shell: Make sure the "active-panel" property is updated The (currently unused) cc_shell_get_active_panel() method is useless unless "active-panel" is actually updated correctly.
Created attachment 214342 [details] [review] cc-panel: Add get_help_uri() vfunc We want to allow panels to point to a specific help page, so add a vfunc for that.
Created attachment 214343 [details] [review] background: Add get_help_uri() implementation
Created attachment 214344 [details] [review] bluetooth: Add get_help_uri() implementation
Created attachment 214345 [details] [review] color: Add get_help_uri() implementation
Created attachment 214346 [details] [review] datetime: Add get_help_uri() implementation
Created attachment 214347 [details] [review] display: Add get_help_uri() implementation
Created attachment 214348 [details] [review] keyboard: Add get_help_uri() implementation
Created attachment 214349 [details] [review] mouse: Add get_help_uri() implementation
Created attachment 214350 [details] [review] network: Add get_help_uri() implementation
Created attachment 214351 [details] [review] online-accounts: Add get_help_uri() implementation
Created attachment 214352 [details] [review] power: Add get_help_uri() implementation
Created attachment 214353 [details] [review] printers: Add get_help_uri() implementation
Created attachment 214354 [details] [review] region: Add get_help_uri() implementation
Created attachment 214355 [details] [review] screen: Add get_help_uri() implementation
Created attachment 214356 [details] [review] sound: Add get_help_uri() implementation
Created attachment 214357 [details] [review] universal-access: Add get_help_uri() implementation
Created attachment 214358 [details] [review] user-accounts: Add get_help_uri() implementation
Created attachment 214359 [details] [review] shell: Make the main window a GtkApplicationWindow This is a prerequisite of using the new GMenu API. Also move the check for small screen sizes introduced in commit 22ed5a9fd5, as GtkApplicationWindows cannot be realized unless their application property has been set.
Created attachment 214360 [details] [review] shell: Add application menu Add a simple application menu containing just "Help" and "Quit".
Patch series approved on IRC, pushing. Attachment 214340 [details] pushed as ce8e120 - shell: Pass the object to show_overview_page(), not its private Attachment 214341 [details] pushed as 7871703 - shell: Make sure the "active-panel" property is updated Attachment 214342 [details] pushed as 6827068 - cc-panel: Add get_help_uri() vfunc Attachment 214343 [details] pushed as f863747 - background: Add get_help_uri() implementation Attachment 214344 [details] pushed as bc18595 - bluetooth: Add get_help_uri() implementation Attachment 214345 [details] pushed as 186d615 - color: Add get_help_uri() implementation Attachment 214346 [details] pushed as afe99e3 - datetime: Add get_help_uri() implementation Attachment 214347 [details] pushed as 4e374a2 - display: Add get_help_uri() implementation Attachment 214348 [details] pushed as 7adcd01 - keyboard: Add get_help_uri() implementation Attachment 214349 [details] pushed as 164d8b5 - mouse: Add get_help_uri() implementation Attachment 214350 [details] pushed as 1bbe93c - network: Add get_help_uri() implementation Attachment 214351 [details] pushed as 4b72311 - online-accounts: Add get_help_uri() implementation Attachment 214352 [details] pushed as e38491e - power: Add get_help_uri() implementation Attachment 214353 [details] pushed as 0c353fb - printers: Add get_help_uri() implementation Attachment 214354 [details] pushed as 79b1189 - region: Add get_help_uri() implementation Attachment 214355 [details] pushed as dc38101 - screen: Add get_help_uri() implementation Attachment 214356 [details] pushed as 45b7938 - sound: Add get_help_uri() implementation Attachment 214357 [details] pushed as fa4a957 - universal-access: Add get_help_uri() implementation Attachment 214358 [details] pushed as a901cc1 - user-accounts: Add get_help_uri() implementation Attachment 214359 [details] pushed as ad4da16 - shell: Make the main window a GtkApplicationWindow Attachment 214360 [details] pushed as c626ba5 - shell: Add application menu
wacom: refer to wacom.page instead of prefs.page in 3.6 user docs.
(In reply to comment #40) > wacom: refer to wacom.page instead of prefs.page in 3.6 user docs. Seriously, you could have filed a new bug here. This comment doesn't even apply to GNOME 3.4 which the original patch was targeting.
Done that in master for gnome 3.6. commit 2a88736cf61395b731b3d3f8f9615ec11248d004 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 12 10:24:19 2012 +0100 wacom: Add link to wacom docs And not the generic control-center docs. https://bugzilla.gnome.org/show_bug.cgi?id=675471#c40