After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675402 - GtkTreeStore remove method
GtkTreeStore remove method
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-03 20:14 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2012-06-08 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added is_ref annotation for TreeStore.remove (1.91 KB, patch)
2012-05-04 15:33 UTC, jessevdk@gmail.com 		needs-work Details | Review

Description Ignacio Casal Quinteiro (nacho) 2012-05-03 20:14:39 UTC 
It should look like:

public bool remove (ref Gtk.TreeIter iter);
Comment 1 jessevdk@gmail.com 2012-05-04 15:33:42 UTC 
Created attachment 213454 [details] [review]
Added is_ref annotation for TreeStore.remove
Comment 2 Luca Bruno 2012-05-05 23:13:15 UTC 
Review of attachment 213454 [details] [review]:

Thanks for the patch. Anyway it would be better to fix that also for gtk+-2.0, and for ListStore.remove as well to break it once and for all.

::: vapi/gtk+-3.0.vapi
@@ +1,1 @@
+/* gtk+-3.0.vapi generated by lt-vapigen, do not modify. */

Final patch should have vapigen instead of lt-vapigen to avoid noise.
Comment 3 Evan Nemerson 2012-06-08 00:55:08 UTC 
commit 45e5ce1459702e6f1369f9309d75942e9cc2bb9d
Author: Jesse van den Kieboom <jesse.vandenkieboom@epfl.ch>
Date:   Thu Jun 7 17:53:29 2012 -0700

    gtk+-2.0, gtk+-3.0: add is_ref annotation for TreeStore.remove
    
    Fixes bug 675402.