After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675396 - Possible bug in _clutter_paint_volume_axis_align
Possible bug in _clutter_paint_volume_axis_align
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterActor
1.10.x
Other Linux
: Normal minor
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-03 19:32 UTC by rmib
Modified: 2012-05-28 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
paint-volume: Use the correct coordinate for axis alignment (1.09 KB, patch)
2012-05-28 13:08 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description rmib 2012-05-03 19:32:45 UTC 
In clutter-paint-volume.c in _clutter_paint_volume_axis_align

if (G_LIKELY (pv->vertices[0].x == pv->vertices[1].x &&
                pv->vertices[0].y == pv->vertices[3].y &&
                pv->vertices[0].z == pv->vertices[4].y))
    {
      pv->is_axis_aligned = TRUE;
      return;
    }

may need to use:
pv->vertices[0].z == pv->vertices[4].z
Comment 1 Emmanuele Bassi (:ebassi) 2012-05-28 13:08:19 UTC 
Created attachment 215124 [details] [review]
paint-volume: Use the correct coordinate for axis alignment

The z coordinate of the origin should be checked against the same
coordinate of the vertex behind it. Given that most actors are flat
surfaces, this check should always succeed.
Comment 2 Emmanuele Bassi (:ebassi) 2012-05-28 13:41:02 UTC 
looks like you're right
Comment 3 Emmanuele Bassi (:ebassi) 2012-05-28 15:01:29 UTC 
Attachment 215124 [details] pushed as 8e9992d - paint-volume: Use the correct coordinate for axis alignment