After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675365 - immulticontext: Always check if the global context id changed
immulticontext: Always check if the global context id changed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Input Methods
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-05-03 11:42 UTC by Rui Matos
Modified: 2012-05-07 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
immulticontext: Always check if the global context id changed (2.50 KB, patch)
2012-05-03 11:42 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-05-03 11:42:43 UTC 
This makes sure that if the gtk-im-module setting changes we update
our internal state immediately on the next event whichever it is.

In particular this fixes the case of the gtk-im-module setting
changing while the user is typing and the slave context remaining the
same, effectively ignoring the setting change.
Comment 1 Rui Matos 2012-05-03 11:42:46 UTC 
Created attachment 213367 [details] [review]
immulticontext: Always check if the global context id changed
Comment 2 Matthias Clasen 2012-05-03 23:58:56 UTC 
I guess this is ok. I've stared at it for a while, without seeing anything wrong. 
I assume you've tested this somewhat ?

- change the gtk-im-module setting while editing

- change the setting while in preedit 

- focus out, change the setting, focus in

etc
Comment 3 Rui Matos 2012-05-07 13:25:40 UTC 
(In reply to comment #2)
> I assume you've tested this somewhat ?

Yes, as far as I can tell it works as well as it did before in all those cases in addition to fix the original problem.
Comment 4 Matthias Clasen 2012-05-07 16:15:53 UTC 
Review of attachment 213367 [details] [review]:

ok then
Comment 5 Rui Matos 2012-05-07 22:55:57 UTC 
Attachment 213367 [details] pushed as a0f155e - immulticontext: Always check if the global context id changed