After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675316 - look for themes in XDG user data dir
look for themes in XDG user data dir
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 523057
 
 
Reported: 2012-05-02 18:02 UTC by William Jon McCann
Modified: 2012-05-14 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme-parser: Don't load themes from our source tree (1.36 KB, patch)
2012-05-02 18:12 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
theme-parser: Look for themes in XDG_USER_DATA_DIR, not in ~/.themes (1.05 KB, patch)
2012-05-02 18:12 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
theme-parser: Look for themes in XDG_USER_DATA_DIR, not in ~/.themes (1.34 KB, patch)
2012-05-02 18:31 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description William Jon McCann 2012-05-02 18:02:28 UTC 
Gtk was just changed to prefer finding theme files in the XDG user data dir. We should probably do the same.

      path = g_build_filename (g_get_user_data_dir (), "themes", name, subpath, NULL);
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-05-02 18:12:00 UTC 
Created attachment 213319 [details] [review]
theme-parser: Don't load themes from our source tree

There aren't any mutter themes in the source tree. You're better off
using jhbuild with gnome-themes-standard.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-05-02 18:12:03 UTC 
Created attachment 213320 [details] [review]
theme-parser: Look for themes in XDG_USER_DATA_DIR, not in ~/.themes
Comment 3 William Jon McCann 2012-05-02 18:18:52 UTC 
Review of attachment 213320 [details] [review]:

::: src/ui/theme-parser.c
@@ +4288,3 @@
       /* We try first in home dir, XDG_DATA_DIRS, then system dir for themes */
 
       /* Try home dir for themes */

Maybe update both comments?
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-05-02 18:31:38 UTC 
Created attachment 213322 [details] [review]
theme-parser: Look for themes in XDG_USER_DATA_DIR, not in ~/.themes
Comment 5 drago01 2012-05-14 17:17:26 UTC 
Review of attachment 213319 [details] [review]:

Yeah makes sense.
Comment 6 drago01 2012-05-14 17:17:57 UTC 
Review of attachment 213322 [details] [review]:

Looks good no migration path but ....
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-05-14 17:28:34 UTC 
Attachment 213319 [details] pushed as da65738 - theme-parser: Don't load themes from our source tree
Attachment 213322 [details] pushed as 81930ca - theme-parser: Look for themes in XDG_USER_DATA_DIR, not in ~/.themes


I'm not sure a migration path is needed for ~/.themes. We can always change our minds, of course.