After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675301 - test-recorder fixes
test-recorder fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-02 15:03 UTC by Rui Matos
Modified: 2012-05-03 07:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test-recorder: Explicitly make the clutter API coordinates doubles (2.06 KB, patch)
2012-05-02 15:03 UTC, Rui Matos 		committed Details | Review
test-recorder: Create the recorder only after the stage is realized (1.97 KB, patch)
2012-05-02 15:03 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-05-02 15:03:34 UTC 
These patches unbreak test-recorder.c
Comment 1 Rui Matos 2012-05-02 15:03:36 UTC 
Created attachment 213298 [details] [review]
test-recorder: Explicitly make the clutter API coordinates doubles

That's what clutter expects and it would crash otherwise.
Comment 2 Rui Matos 2012-05-02 15:03:40 UTC 
Created attachment 213299 [details] [review]
test-recorder: Create the recorder only after the stage is realized

The recorder needs the stage's XID so it can only be created after the
stage is realized.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-05-02 15:05:44 UTC 
Review of attachment 213298 [details] [review]:

Yes.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-05-02 15:13:22 UTC 
Review of attachment 213299 [details] [review]:

This seems fine as well.
Comment 5 Rui Matos 2012-05-03 07:30:36 UTC 
Attachment 213298 [details] pushed as cb5941e - test-recorder: Explicitly make the clutter API coordinates doubles
Attachment 213299 [details] pushed as d579cd1 - test-recorder: Create the recorder only after the stage is realized