After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675214 - Contacts not in groups after a restart
Contacts not in groups after a restart
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-01 07:15 UTC by Guillaume Desmottes
Modified: 2012-06-13 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
empathy_client_factory_dup_contact_features: request groups and client-types (1.18 KB, patch)
2012-06-13 13:32 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-05-01 07:15:06 UTC 
- Start Empathy and connect accounts
- All the contacts are fetched and displayed in their IM groups
- Quit Empathy while staying connected and then restart it
- All IM contacts are now 'Ungroupped'

I think this is a regression with Folks master so may be a Folks bug. But the groups seem fine in folks-inspect so that may be an Empathy bug as well.
Comment 1 Guillaume Desmottes 2012-05-01 07:32:28 UTC 
So yeah that looks like a Folks regression; probably introduced when we switched to ContactList.

The Individual we receive from the aggregator doesn't have any group and the 'group-changed' signal is not fired afterward.
Comment 2 Xavier Claessens 2012-05-01 09:03:36 UTC 
I think this is because EmpathyClientFactory does not ask for TP_CONTACT_FEATURE_CONTACT_GROUPS. And empathy prepare the AM before preparing folks, so when folks set its features on the factory, all TpContact are already created and so won't be upgraded.
Comment 3 Guillaume Desmottes 2012-06-13 13:30:55 UTC 
Yeah you're right. Thanks.
Comment 4 Guillaume Desmottes 2012-06-13 13:32:35 UTC 
Created attachment 216278 [details] [review]
empathy_client_factory_dup_contact_features: request groups and client-types

Empathy prepares the AM before preparing folks, so when folks set its features
on the factory, all TpContact are already created and so won't be upgraded.
Comment 5 Guillaume Desmottes 2012-06-13 13:34:57 UTC 
Attachment 216278 [details] pushed as ad74b5a - empathy_client_factory_dup_contact_features: request groups and client-types