GNOME Bugzilla – Bug 675178
SMS "Completed" signal is not sent.
Last modified: 2012-09-12 06:03:29 UTC
ModemManager on ChromiumOS, corresponding to rev. e8bc2f41e710ed9e3a2576538f5c9fe74b7ef6db from master. When a new single-part message arrives, an "Added" signal is sent but the "Completed" signal is not sent, contrary to the introspection docs. I can't tell what the story is for multipart messages due to #675177.
Further discussion in the following thread: https://mail.gnome.org/archives/networkmanager-list/2012-April/msg00105.html
Based on the discussion in the previously listed thread, not sending the Completed signal is not a bug; the bug is that the Completed signal is still around while it is no longer needed. Some reasoning from the thread: > We emit "Added" if we got a singlepart message or whenever we get the > first part of a multipart message. In the latter case, the state of the > SMS will be RECEIVING, until the last part is received and the message > assembled, which is when the state of the SMS goes to RECEIVED. I would > vote for completely removing the "Completed" emitted in the Messaging > interface; and instead just rely on each SMS state changes... At least > that was my original idea when I skipped emitting the "Completed" signal > all together. > Since we have individual message state, Completed doesn't seem that > useful. They would be exactly the same thing except the state conveys > more information, which is more useful than Completed. So, what I did fix is the introspection XML, which still listed the "Completed" signal: commit 73ced242da75abf63a1b5be47ad95123a9e53a3f Author: Aleksander Morgado <aleksander@lanedo.com> Date: Wed Sep 12 07:59:39 2012 +0200 api: remove `Completed' signal from the Messaging interface This signal is no longer needed, as the individual state changes of the SMS objects are enough to know their correct status of completion. See https://bugzilla.gnome.org/show_bug.cgi?id=675178