After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675156 - mpegdemux: the ts demuxer ignores/discards NEWSEGMENT events that are already in time format
mpegdemux: the ts demuxer ignores/discards NEWSEGMENT events that are already...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-30 13:18 UTC by Frank Hestvik
Modified: 2014-02-25 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for GST_FORMAT_TIME case (609 bytes, patch)
2012-04-30 13:20 UTC, Frank Hestvik
none Details | Review

Description Frank Hestvik 2012-04-30 13:18:08 UTC
I've made a push-based source plugin for GStreamer that downloads adaptive streams over HTTP. Basically I fetch the media by piecemeal segments from a web server by giving parameters for time offset and quality layer. Internally the GST plugin uses GST_FORMAT_TIME (the sizes of the individual media segments that will be fetched to make up the viewed stream are not known before they are fetched, so it is meaningless to talk about byte offset into the stream).

I discovered that when I use it with decodebin/playbin, seeking didn't work. I traced this back to this module and the fact that it doesn't forward NEWSEGMENT events to its sinks, even though I emit them with correct times in GST_FORMAT_TIME format. This seems like a bug to me. It simply attempts to convert NEWSEGMENT events that are specified in byte format, and ignores/discards the rest.

(Perhaps all NEWSEGMENT events that are not in byte format should be forwarded?)
Comment 1 Frank Hestvik 2012-04-30 13:20:05 UTC
Created attachment 213104 [details] [review]
Proposed patch for GST_FORMAT_TIME case

I've made this proposed patch to show what I mean in code.

With this patch my plugin works, and it is what my company uses internally.
Comment 2 Edward Hervey 2013-09-29 09:59:41 UTC
This patch is for the old mpegtsdemux which was not ported to 1.x. Can you check with 1.x ?
Comment 3 Edward Hervey 2014-02-25 09:25:55 UTC
Marking as obsolete.