After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675144 - phone-details.vala:72: Empty phone number passed to PhoneFieldDetails.
phone-details.vala:72: Empty phone number passed to PhoneFieldDetails.
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-30 12:41 UTC by Guillaume Desmottes
Modified: 2012-04-30 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tpf-persona: ignore empty email or phone number (2.20 KB, patch)
2012-04-30 12:50 UTC, Guillaume Desmottes
none Details | Review
tpf-persona: ignore empty email or phone number (2.81 KB, patch)
2012-04-30 13:20 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-04-30 12:41:57 UTC
Got this when I fetched ContactInfo from a bunch of Telepathy contacts.

(gnome-contacts:26966): folks-WARNING **: phone-details.vala:72: Empty phone number passed to PhoneFieldDetails.



  • #0 g_logv
    at gmessages.c line 758
  • #1 g_log
    at gmessages.c line 792
  • #2 folks_phone_field_details_construct
    at /home/cassidy/gnome/folks/folks/phone-details.vala line 72
  • #3 folks_phone_field_details_new
    at /home/cassidy/gnome/folks/folks/phone-details.vala line 67
  • #4 _tpf_persona_contact_notify_contact_info
    at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona.vala line 841
  • #5 _tpf_persona___lambda16_
    at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona.vala line 745
  • #6 __tpf_persona___lambda16__g_object_notify
    at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona.vala line 743
  • #7 g_cclosure_marshal_VOID__PARAM
    at gmarshal.c line 1042
  • #8 g_closure_invoke
    at gclosure.c line 777
  • #9 signal_emit_unlocked_R
    at gsignal.c line 3547
  • #10 g_signal_emit_valist
    at gsignal.c line 3296
  • #11 g_signal_emit
    at gsignal.c line 3352
  • #12 g_object_dispatch_properties_changed
    at gobject.c line 1041
  • #13 g_object_notify_by_spec_internal
    at gobject.c line 1133
  • #14 g_object_notify
    at gobject.c line 1175
  • #15 contact_maybe_set_info
    at contact.c line 3012
  • #16 contact_info_changed
    at contact.c line 3024
  • #17 _tp_cli_connection_interface_contact_info_invoke_callback_for_contact_info_changed
    at _gen/tp-cli-connection-body.h line 10133
  • #18 tp_proxy_signal_invocation_run
    at proxy-signals.c line 268
  • #19 g_idle_dispatch
    at gmain.c line 4657
  • #20 g_main_dispatch
    at gmain.c line 2539
  • #21 g_main_context_dispatch
    at gmain.c line 3075
  • #22 g_main_context_iterate
    at gmain.c line 3146
  • #23 g_main_context_iteration
    at gmain.c line 3207
  • #24 g_application_run
    at gapplication.c line 1496
  • #25 _vala_main
    at main.c line 73
  • #26 main
    at main.c line 84

Comment 1 Guillaume Desmottes 2012-04-30 12:50:37 UTC
Created attachment 213101 [details] [review]
tpf-persona: ignore empty email or phone number

The interface implementation raises an error if we pass it an empty value.
Comment 2 Xavier Claessens 2012-04-30 13:06:48 UTC
+1, no other fields that could have similar fix?
Comment 3 Guillaume Desmottes 2012-04-30 13:20:29 UTC
Created attachment 213105 [details] [review]
tpf-persona: ignore empty email or phone number

The interface implementation raises an error if we pass it an empty value.
Comment 4 Guillaume Desmottes 2012-04-30 13:25:21 UTC
Merged to 0.6.

Attachment 213105 [details] pushed as 79f7983 - tpf-persona: ignore empty email or phone number