After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675134 - shmsrc: add an shm-area-name property
shmsrc: add an shm-area-name property
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2012-04-30 11:43 UTC by Guillaume Emont (guijemont)
Modified: 2015-04-02 22:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

shmsrc: add an shm-area-name property (4.12 KB, patch)
2012-04-30 11:43 UTC, Guillaume Emont (guijemont)
needs-work Details | Review
shmsink: add an shm-area-name property (4.06 KB, patch)
2012-05-02 13:35 UTC, Guillaume Emont (guijemont)
committed Details | Review

Description Guillaume Emont (guijemont) 2012-04-30 11:43:59 UTC
Created attachment 213096 [details] [review]
shmsrc: add an shm-area-name property

The shm-area-property tells the name of the shm area used by the element. This
is useful for cases where shmsink is not able to clean up (calling
shm_unlink()), e.g. if it is in a sandbox.

For this patch, I had to change a bit the logic in shmpipe.c: the presence of shm_area_name was used to make the distinction between a reading or writing pipe, I've put an is_writer boolean there instead, so that I can ensure that shm_area_name is here with the correct value when we are in reading mode.
Then it's just a matter of adding an accessor and using it to export a property in shmsrc.
Comment 1 Olivier Crête 2012-04-30 18:57:28 UTC
Review of attachment 213096 [details] [review]:

::: sys/shm/gstshmsrc.c
@@ +208,3 @@
+        g_value_set_string (value, sp_get_shm_area_name (self->pipe->pipe));
+      else
+        g_value_set_string (value, NULL);

The else bit here is not necessary
Comment 2 Guillaume Emont (guijemont) 2012-05-02 13:35:46 UTC
Created attachment 213276 [details] [review]
shmsink: add an shm-area-name property

New version removing useless g_value_set_string() call.
Comment 3 Nicolas Dufresne (ndufresne) 2014-05-20 21:42:25 UTC
Olivier ?
Comment 4 Nicolas Dufresne (ndufresne) 2015-04-02 22:13:09 UTC
Attachment 213276 [details] pushed as 48880ea - shmsink: add an shm-area-name property
Comment 5 Nicolas Dufresne (ndufresne) 2015-04-02 22:14:28 UTC