After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675122 - opus: FEC/PLC does not work
opus: FEC/PLC does not work
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-30 08:49 UTC by Vincent Penquerc'h
Modified: 2012-06-11 09:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vincent Penquerc'h 2012-04-30 08:49:21 UTC
Enabling FEC/PLC does not sound any different from disabled when packets are dropped. It's supposed to be supported though, and the right code paths appear to be taken from a first debugging attempt.

Reminder bug for me to look at when I get a moment.
Comment 1 Vincent Penquerc'h 2012-06-11 09:10:44 UTC
Fixed some days ago, forgot to close.

commit 6c3e13197ebc81df26d5e01a161a13e8e4b66bf4
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Apr 30 14:40:02 2012 +0100

    opusdec: fix lost packet handling for FEC/PLC
    
    The base audio decoder sends zero size packets, not NULL buffers,
    to signal dropped packets.