After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675087 - build: Add --disable-documentation
build: Add --disable-documentation
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-29 16:25 UTC by Colin Walters
Modified: 2012-05-01 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add --disable-documentation (1.34 KB, patch)
2012-04-29 16:25 UTC, Colin Walters
none Details | Review
build: Add --disable-documentation (1.73 KB, patch)
2012-04-30 20:04 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2012-04-29 16:25:16 UTC
Documentation is the source of many cyclical build loops.  Allow
operating system builders to manually cut these cycles initially
by disabling documentation for a first pass.
Comment 1 Colin Walters 2012-04-29 16:25:18 UTC
Created attachment 213054 [details] [review]
build: Add --disable-documentation
Comment 2 Ray Strode [halfline] 2012-04-30 19:07:18 UTC
any chance you could get --disable-documentation in gnome-doc-utils ?  Also if you go this route, you need to make DISTCHECK_CONFIGURE_FLAGS --enable-documentation
Comment 3 Colin Walters 2012-04-30 20:01:29 UTC
(In reply to comment #2)
> any chance you could get --disable-documentation in gnome-doc-utils ?

gnome-doc-utils itself has a --disable-documentation argument (see 8b4cb9d332b84db970bf446ad9576ad98ba448e5 ) so what I assume you mean here is have it globally add a configure argument via adding it to gnome-doc-utils.m4.

While that sounds nice, there are two problems:

1) Not every component generates documentation solely via gnome-doc-utils; namely, using xslt to generate man pages is pretty common.  It's been nice so far to have --disable-documentation disable everything.

2) Even if adding it to gnome-doc-utils.m4, I still need to touch every component's Makefile rules to have it use an automake conditional, and if we have to touch everything anyways, having a copy of the 4 lines to add a configure argument is about as easy.

>  Also if
> you go this route, you need to make DISTCHECK_CONFIGURE_FLAGS
> --enable-documentation

Since it defaults to on, you'll get it in distcheck by default.  But I can add it there too to ensure one can run dist/distcheck from a source tree configured this way.
Comment 4 Colin Walters 2012-04-30 20:04:21 UTC
Created attachment 213135 [details] [review]
build: Add --disable-documentation

Now use --enable-documentation in DISTCHECK_CONFIGURE_FLAGS
Comment 5 Ray Strode [halfline] 2012-04-30 20:39:19 UTC
Review of attachment 213135 [details] [review]:

push push
Comment 6 Colin Walters 2012-05-01 17:47:45 UTC
Attachment 213135 [details] pushed as 7764799 - build: Add --disable-documentation