After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674991 - wait for QUIT before exiting
wait for QUIT before exiting
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openconnect
git master
Other Linux
: Normal normal
: ---
Assigned To: David Woodhouse
David Woodhouse
Depends on:
Blocks:
 
 
Reported: 2012-04-27 19:57 UTC by Dan Winship
Modified: 2012-04-27 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Wait for "QUIT" command before exiting (1.51 KB, patch)
2012-04-27 19:57 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2012-04-27 19:57:43 UTC 
as noted in https://bugzilla.gnome.org/show_bug.cgi?id=674961#c6, you're doing it wrong
Comment 1 Dan Winship 2012-04-27 19:57:58 UTC 
Created attachment 212994 [details] [review]
Wait for "QUIT" command before exiting

According to the NM VPN auth dialog "protocol", the helper isn't
supposed to exit until the caller sends "QUIT". Doing otherwise
creates a race condition. Copy in the code that the other plugins use
for this.
Comment 2 David Woodhouse 2012-04-27 21:31:34 UTC 
Review of attachment 212994 [details] [review]:

Looks good; thanks
Comment 3 Dan Winship 2012-04-27 21:37:09 UTC 
Attachment 212994 [details] pushed as d0c4ce1 - Wait for "QUIT" command before exiting