GNOME Bugzilla – Bug 674986
Use new GTK bookmarks location
Last modified: 2012-04-30 14:18:01 UTC
A consequence of bug 646631 will be that the default bookmarks location will change to ~/.config/gtk/bookmarks. Will attach a patch to support that in Nautilus.
Created attachment 212989 [details] [review] Use new GTK bookmarks location If it doesn't exist fallback to reading from the old location but always write to the new location.
Review of attachment 212989 [details] [review]: ::: src/nautilus-bookmark-list.c @@ +517,3 @@ + if (!g_file_query_exists (file, NULL)) { + file = nautilus_bookmark_list_get_legacy_file (); + } Unfortunately we can't really trigger sync I/O in this code path, since the home directory might be e.g. on a NFS share and this will be called frequently. You will have to wrap this in an async operation, or wrap both the g_file_load_contents() and the g_file_query_info() operations in a thread e.g. with g_simple_async_result_run_in_thread() or g_io_scheduler_push_job(). @@ +605,3 @@ + g_mkdir_with_parents (path, 0700); + g_free (path); + g_object_unref (parent); Same here, g_mkdir_with_parents() will do sync I/O.
Attachment 212989 [details] pushed as ed90577 - Use new GTK bookmarks location Pushed to master with an additional patch to always avoid sync I/O while loading/saving the file.