After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674982 - welcome: Use Linux PR_SET_PDEATHSIG to ensure dbus-daemon dies when we do
welcome: Use Linux PR_SET_PDEATHSIG to ensure dbus-daemon dies when we do
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-27 17:03 UTC by Colin Walters
Modified: 2012-04-27 22:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
welcome: Use Linux PR_SET_PDEATHSIG to ensure dbus-daemon dies when we do (1.48 KB, patch)
2012-04-27 17:03 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2012-04-27 17:03:49 UTC
It's convenient for debugging to "kill -9 $(pidof gdm-binary)", but
presently because gdm runs bare "dbus-launch" which daemonizes,
it won't terminate when the parent gdm welcome session dies.

Other approaches here are to use "dbus-daemon --no-fork --print-address"
directly as a child, and kill it when we get SIGTERM:
http://git.gnome.org/browse/at-spi2-core/tree/bus/at-spi-bus-launcher.c

But this is an easy fix, even if it only works on Linux.
Comment 1 Colin Walters 2012-04-27 17:03:52 UTC
Created attachment 212983 [details] [review]
welcome: Use Linux PR_SET_PDEATHSIG to ensure dbus-daemon dies when we do
Comment 2 Ray Strode [halfline] 2012-04-27 17:07:52 UTC
can you just not use -9 ? and stick with SIGTERM ?
Comment 3 Ray Strode [halfline] 2012-04-27 17:09:33 UTC
Review of attachment 212983 [details] [review]:

we do explicitly kill dbus-daemon I think. anyway, no problem with the patch.
Comment 4 Colin Walters 2012-04-27 22:06:52 UTC
Attachment 212983 [details] pushed as c030b9b - welcome: Use Linux PR_SET_PDEATHSIG to ensure dbus-daemon dies when we do