After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674935 - disable wacom support on OpenBSD
disable wacom support on OpenBSD
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
3.4.x
Other OpenBSD
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-27 10:57 UTC by Antoine Jacoutot
Modified: 2012-05-17 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't build wacom on OpenBSD (1.52 KB, patch)
2012-04-27 10:57 UTC, Antoine Jacoutot
needs-work Details | Review
only try to build wacom on linux (1.64 KB, patch)
2012-04-27 11:42 UTC, Antoine Jacoutot
committed Details | Review

Description Antoine Jacoutot 2012-04-27 10:57:28 UTC
Created attachment 212948 [details] [review]
don't build wacom on OpenBSD

Hi.

Wacom support requires udev which is not available on that OS.
So adapt the conditional that was introduced to disable wacom on s390 and do the same for OpenBSD.

Toughts?
Comment 1 Bastien Nocera 2012-04-27 11:05:02 UTC
Review of attachment 212948 [details] [review]:

It doesn't work on non-Linux actually, so you should use that in the switch statement.

The same fix needs to happen for gnome-control-center as well.
Comment 2 Antoine Jacoutot 2012-04-27 11:42:23 UTC
Created attachment 212952 [details] [review]
only try to build wacom on linux

Hi Bastien.

Thanks for the answer. I have updated the patch according to your comments (hopefully). As for gnome-control-center, it's on my list but I wanted to make sure to first have a correct way to disable it in settings-daemon.
Comment 3 Bastien Nocera 2012-05-17 17:35:05 UTC
Pushed to master and gnome-3-4
Comment 4 Bastien Nocera 2012-05-17 17:36:04 UTC
I'll be waiting for your gnome-control-center patch!