After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674932 - popupMenu: Fix RemoteMenu items with boolean state action
popupMenu: Fix RemoteMenu items with boolean state action
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-27 10:06 UTC by Florian Müllner
Modified: 2012-04-29 08:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popupMenu: Fix RemoteMenu items with boolean state action (1.15 KB, patch)
2012-04-27 10:06 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-04-27 10:06:32 UTC 
See patch.
Comment 1 Florian Müllner 2012-04-27 10:06:35 UTC 
Created attachment 212943 [details] [review]
popupMenu: Fix RemoteMenu items with boolean state action

Stateful actions are expected to pass their state when activated,
but we currently only do this for actions with a string state.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-04-27 10:21:17 UTC 
Review of attachment 212943 [details] [review]:

Makes sense.
Comment 3 Florian Müllner 2012-04-27 10:30:53 UTC 
Attachment 212943 [details] pushed as 7293ddb - popupMenu: Fix RemoteMenu items with boolean state action
Comment 4 Giovanni Campagna 2012-04-27 16:53:05 UTC 
Wait... are they really expected to do so? Is it documented somewhere?
Why doesn't bloatpad (which is the reference implementation) expect that?
And what is change_action_state for, if activate can fully control truthiness?
Comment 5 Florian Müllner 2012-04-29 08:41:02 UTC 
Gah, you are right - looks like I got confused between handling of string state and the assert in g_simple_action_activate() ... reverted.