GNOME Bugzilla – Bug 674920
mpeg2enc: discards downstream mpegversion restrictions
Last modified: 2018-11-03 13:11:53 UTC
Created attachment 212932 [details] Sample program Using the attached program with only mpeg2enc available (no ffenc_mpeg2video) to simulate the situation on Ubuntu 12.04 where encodebin seems to chose mpeg2enc over ffenc_mpeg2video (bug 672439)
Created attachment 212934 [details] GST_DEBUG output GST_DEBUG=encodebin:5,mpeg2enc:5
This is due to a capsfilter video/mpeg,mpegversion=2,systemstream=false downstream of mpeg2enc, which does not consider that one and produces mpegversion=1 (as dictated by the default format setting). So maybe we should add a 'auto' option to the format property in which case mpeg2enc should negotiate with downstream, though that might also be a confusing way to go about it.
I think it should negotiate as much as possible based on downstream caps restrictions, if there are any. And we should change the default at least to Generic Mpeg-2 or something (I thought I'd done that already, but maybe it was elsewhere such as in mplex).
Agreed, unfortunately the downstream restrictions do not readily/evidently map to a particular choice of format (where there are still a few for version 1, 2 etc). One could try to include resolutions wrt DVD but that still leaves some ambiguity.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/70.