After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674864 - Missing tp-chat signals
Missing tp-chat signals
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-26 11:34 UTC by Guillaume Desmottes
Modified: 2012-05-02 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tp-chat: add the 'member-renamed' signal (1.69 KB, patch)
2012-04-26 11:53 UTC, Guillaume Desmottes 		committed Details | Review
tp-chat: add the 'members-changed' signal (2.14 KB, patch)
2012-04-26 11:53 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-04-26 11:34:04 UTC 
I got this in empathy-chat master:

(empathy-chat:8736): GLib-GObject-WARNING **: gsignal.c:2455: signal `member-renamed' is invalid for instance `0x970000'

This signal uses to be implemented by the EmpathyContactList interface which has gone away.

Thanks GObject for having a not safe signalling system...
Comment 1 Guillaume Desmottes 2012-04-26 11:53:07 UTC 
Created attachment 212872 [details] [review]
tp-chat: add the 'member-renamed' signal

It uses to be implemented by the EmpathyContactList interface which has been
removed.
Comment 2 Guillaume Desmottes 2012-04-26 11:53:10 UTC 
Created attachment 212873 [details] [review]
tp-chat: add the 'members-changed' signal

It uses to be implemented by the EmpathyContactList interface which has been
removed.
Comment 3 Xavier Claessens 2012-05-02 09:30:33 UTC 
Looks good. Just wondering why you're using SIG_ for them and not others.
Comment 4 Guillaume Desmottes 2012-05-02 09:32:11 UTC 
Attachment 212872 [details] pushed as e889f1a - tp-chat: add the 'member-renamed' signal
Attachment 212873 [details] pushed as 55b19d4 - tp-chat: add the 'members-changed' signal
Comment 5 Guillaume Desmottes 2012-05-02 09:32:48 UTC 
(In reply to comment #3)
> Looks good. Just wondering why you're using SIG_ for them and not others.

I use SIG_ in newly written code but didn't bother changing existing code to reduce the diff.