After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674860 - Modernize EmpathyNewChatroomDialog
Modernize EmpathyNewChatroomDialog
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 673989
 
 
Reported: 2012-04-26 10:40 UTC by Guillaume Desmottes
Modified: 2012-05-10 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
new-chatroom-dialog: port to TP coding style (50.96 KB, patch)
2012-04-26 10:41 UTC, Guillaume Desmottes 		committed Details | Review
chatroom-dialog: re-order some functions (25.80 KB, patch)
2012-04-26 10:41 UTC, Guillaume Desmottes 		committed Details | Review
Turn EmpathyNewChatroomDialog to a GtkDialog sub-class (55.79 KB, patch)
2012-04-26 10:41 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-04-26 10:40:41 UTC 
I was about to work on EmpathyNewChatroomDialog and did some cleanup/modernization first.
Comment 1 Guillaume Desmottes 2012-04-26 10:41:12 UTC 
Created attachment 212863 [details] [review]
new-chatroom-dialog: port to TP coding style
Comment 2 Guillaume Desmottes 2012-04-26 10:41:15 UTC 
Created attachment 212864 [details] [review]
chatroom-dialog: re-order some functions

Let's just get rid of all these stupid prototypes.
Comment 3 Guillaume Desmottes 2012-04-26 10:41:17 UTC 
Created attachment 212865 [details] [review]
Turn EmpathyNewChatroomDialog to a GtkDialog sub-class
Comment 4 Guillaume Desmottes 2012-05-10 08:31:21 UTC 
Attachment 212863 [details] pushed as 3d4484b - new-chatroom-dialog: port to TP coding style
Attachment 212864 [details] pushed as 98c9a19 - chatroom-dialog: re-order some functions
Attachment 212865 [details] pushed as 7842711 - Turn EmpathyNewChatroomDialog to a GtkDialog sub-class