GNOME Bugzilla – Bug 674845
[PATCH] Make the PiTiVi formatter optional
Last modified: 2012-04-26 13:17:04 UTC
We don't necessarily want the PiTiVi formatter code (and the libxml2 dep it pulls in) on embedded platforms. I'm including a couple of patches to allow disabling this and stubbing the related API. I think we need to do one of the following to make this clean and non-confusing from the client side -- either we provide the ability to check at run-time whether support is available, or we put a big warning note that only people who know what they're doing should be using this configure option. Thoughts?
Created attachment 212848 [details] [review] formatter: Make PiTiVi formatter optional This makes the PiTiVi formatter optional by stubbing it out the API calls if disabled. This is handy on systems where we don't want this support and wish to avoid the additional libxml2 dependency.
Created attachment 212849 [details] [review] android: Disable PiTiVi formatter at configure time We don't need it and this works around the unavailability of libxml2 in the NDK.
I am planning to rewrite the formatter using GMarkupParser as the formatter is not really high quality code and thus unmaintainable. Note that the PiTiVi formatter is the only one that actually handles more advanced use of GES (effects, transitions...). I guess you do not need it yet though. So we could either merge this patch for now, and when the dependency to libxml is removed, remove that option or you apply it for the android builds for now and wait for the dep to be removed.
I don't believe this is urgent enough to merit pushing and then reverting in a while. Closing this bug, then.