After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674807 - spinbutton: port to GtkIconHelper
spinbutton: port to GtkIconHelper
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkSpinButton
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-25 15:26 UTC by Cosimo Cecchi
Modified: 2012-04-26 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
spinbutton: port to GtkIconHelper (4.58 KB, patch)
2012-04-25 15:26 UTC, Cosimo Cecchi 		accepted-commit_now Details | Review

Description Cosimo Cecchi 2012-04-25 15:26:09 UTC 
Saves a bunch of code
Comment 1 Cosimo Cecchi 2012-04-25 15:26:11 UTC 
Created attachment 212796 [details] [review]
spinbutton: port to GtkIconHelper

Instead of doing our own lookup for symbolic icons and rendering the
pixbuf, use GtkIconHelper as other widgets do, which saves a bunch of
code.
Comment 2 Matthias Clasen 2012-04-26 03:25:35 UTC 
Review of attachment 212796 [details] [review]:

Looks good to me
Comment 3 Cosimo Cecchi 2012-04-26 17:36:12 UTC 
Attachment 212796 [details] pushed as 5538552 - spinbutton: port to GtkIconHelper

Thanks, pushed.
Comment 4 Cosimo Cecchi 2012-04-26 17:44:20 UTC 
Thanks, pushed.